WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#24114 closed enhancement (fixed)

Twenty Thirteen: Remove hgroup

Reported by: obenland Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

With the removal of the <hrgroup> element from the spec, let's remove it in Twenty Thirteen too.

I'm pretty sure we'd blow back compat if we'd attempt to remove it in older themes.

Attachments (3)

24114.diff (3.0 KB) - added by obenland 2 years ago.
24114.1.diff (4.5 KB) - added by lancewillett 2 years ago.
24114.2.diff (4.3 KB) - added by lancewillett 2 years ago.

Download all attachments as: .zip

Change History (12)

@obenland2 years ago

comment:1 follow-up: @lancewillett2 years ago

With the removal of the <hrgroup> element from the spec

hgroup? Can you please link to discussion and relevant docs for the removal?

comment:3 @lancewillett2 years ago

Can we get rid of the extra div element? Seems like we could apply the same styles to the anchor element, since it's a block-level element and always present.

@lancewillett2 years ago

comment:4 @lancewillett2 years ago

.1 removes the entire element (hgroup or div) and moves CSS and JS references to class value of "masthead" instead.

comment:5 follow-up: @philiparthurmoore2 years ago

How do you plan on dealing with the hgroup cruft in html5.js?

comment:6 @philiparthurmoore2 years ago

  • Cc philip@… added

comment:7 in reply to: ↑ 5 @lancewillett2 years ago

Replying to philiparthurmoore:

How do you plan on dealing with the hgroup cruft in html5.js?

Leaving it for now, will push an update once the author has a new version. It's very minor, in my opinion.

@lancewillett2 years ago

comment:8 @lancewillett2 years ago

.2 updates to use home-link as class value instead of moving masthead.

comment:9 @lancewillett2 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24072:

Twenty Thirteen: remove hgroup from the theme markup structure since it's been dropped from HTML5 spec. Props obenland for the starter patch. Fixes #24114.

Note: See TracTickets for help on using tickets.