WordPress.org

Make WordPress Core

Opened 12 months ago

Closed 11 months ago

Last modified 11 months ago

#24115 closed defect (bug) (fixed)

'Manage Locations' tab should be hidden for zero locations/no menus support

Reported by: DrewAPicture Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Menus Keywords: has-patch 3.6-menus
Focuses: Cc:

Description

If you're working with a theme that doesn't have any registered menu locations, the 'Manage Locations' tab should be hidden. Patch attached.

Attachments (2)

24115.diff (1.6 KB) - added by DrewAPicture 12 months ago.
24115.2.diff (2.4 KB) - added by DrewAPicture 11 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 DrewAPicture12 months ago

24115.diff also fixes display of the 'This theme does not natively support menus' message based on number of theme locations rather than number of menus.

DrewAPicture12 months ago

comment:2 DrewAPicture11 months ago

It's worth mentioning that if we don't hide the tab for this case, they'll visit the tab, it'll say 'Your theme supports 0 menus ...' and the list table will be empty, which is just bad UX.

Last edited 11 months ago by DrewAPicture (previous) (diff)

comment:3 DrewAPicture11 months ago

  • Summary changed from 'Manage Locations' tab should be hidden for zero menus and/or zero locations to 'Manage Locations' tab should be hidden for zero locations/no menus support

comment:4 SergeyBiryukov11 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 24217:

Don't show "Manage Locations" tab if the theme has no menu locations defined. props DrewAPicture. fixes #24115.

comment:5 DrewAPicture11 months ago

24115.2.diff brings the no-support notice text more in line with the help tab, with the Widgets screen linked:

"Your theme does not natively support menus, but you can use them in sidebars by adding a Custom Menus widget on the Widgets screen."

DrewAPicture11 months ago

comment:6 SergeyBiryukov11 months ago

In 24218:

Make the notice on Edit Menus screen more in line with the help text. props DrewAPicture. see #24115.

Note: See TracTickets for help on using tickets.