Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#24126 closed enhancement (fixed)

Twenty Thirteen: Use core function for featured galleries

Reported by: obenland's profile obenland Owned by: nacin's profile nacin
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Themes, especially default themes should not deal with regex in functions.php.
Let's move the functionality into core and just use a filter.

Attachments (3)

24126.diff (2.2 KB) - added by obenland 12 years ago.
24126.2.diff (4.8 KB) - added by wonderboymusic 12 years ago.
24126.3.diff (5.2 KB) - added by wonderboymusic 12 years ago.

Download all attachments as: .zip

Change History (12)

@obenland
12 years ago

#1 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24029:

Twenty Thirteen: Use the_post_format_gallery(). props obenland, fixes #24126.

#2 @nacin
12 years ago

In 24033:

Twenty Thirteen: Don't use the_post_format_gallery() as it does not exist (yet). see #24126.

#3 @nacin
12 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#4 @jeherve
12 years ago

  • Cc jeremy+wp@… added

#5 @obenland
12 years ago

Patch works for Twenty Thirteen as expected!

#6 @lancewillett
12 years ago

Patch tested out well for me, also.

@nacin Can you review and commit, please?

#7 @lancewillett
12 years ago

  • Keywords commit added

#8 @lancewillett
12 years ago

Still needs another look and commit from Nacin.

#9 @markjaquith
12 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 24093:

the_post_format_gallery() (and Twenty Thirteen using it).

fixes #24126. props obenland, wonderboymusic.

Note: See TracTickets for help on using tickets.