Opened 11 years ago
Closed 9 years ago
#24128 closed enhancement (fixed)
Twenty Eleven: add postMessage support for header_textcolor
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
Similar to Twenty Twelve and Twenty Thirteen, this would add immediate visual feedback in the Theme Customizer UI when header text is hidden, or its color value changes.
Attachments (4)
Change History (19)
#2
@
11 years ago
- Keywords early added
- Milestone changed from 3.6 to Future Release
Wow, this is more involved than I imagined. Let's bump to 3.7, too late for thorough testing before 3.6.
#4
@
10 years ago
- Milestone changed from 3.7 to Future Release
No signs of testing - move it back and commit it if you did, lance. :)
#5
@
10 years ago
- Keywords needs-refresh added; early removed
- Milestone changed from Future Release to 4.0
This ticket was mentioned in IRC in #wordpress-themes by obenland. View the logs.
9 years ago
#7
@
9 years ago
- Milestone changed from 4.0 to Future Release
No movement, let's look at it after 4.0.
#8
@
9 years ago
Tested, modified a little to suit the way most of the other twenty* themes format as well. Ran into the issue of when you chose not to have the text and tried to re-enable the text would not reappear. As it turns out it was the $header.hide()
that was the culprit.
Tried with a child theme and no errors.
#9
@
9 years ago
Applied patch to Rev 29493, and verified that postMessage works as advertised.
After discussing with Nick, he pointed out that the patch was created relative to the theme folder, and it should be re-worked to be created relative to the root.
An updated patch is forthcoming.
This ticket was mentioned in Slack in #core-themes by lancewillett. View the logs.
9 years ago
#12
@
9 years ago
Tested the patch and it seems the postMessage is working in the Customizer but I noticed that the padding-right
applied by #branding .only-search + #access div ul
rule is making the main menu smaller in smartphones: https://cloudup.com/iufYxgz6r01. Adding padding-right: 0
in the proper responsive rule will fix it.
24128.diff should do the trick. Needs testing to see if it breaks any child themes since it changes a couple selectors.