Make WordPress Core

Opened 13 years ago

Closed 11 years ago

#24128 closed enhancement (fixed)

Twenty Eleven: add postMessage support for header_textcolor

Reported by: lancewillett Owned by: lancewillett
Priority: normal Milestone: 4.2
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Similar to Twenty Twelve and Twenty Thirteen, this would add immediate visual feedback in the Theme Customizer UI when header text is hidden, or its color value changes.

Attachments (4)

24128.diff (4.8 KB ) - added by kovshenin 13 years ago.
24128.2.diff (4.5 KB ) - added by jcastaneda 12 years ago.
24128.3.diff (4.9 KB ) - added by DavidTheMachine 12 years ago.
24128.2 applied relative to the root directory
24128.4.diff (3.1 KB ) - added by lancewillett 11 years ago.

Download all attachments as: .zip

Change History (19)

@kovshenin
13 years ago

#1 @kovshenin
13 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

24128.diff should do the trick. Needs testing to see if it breaks any child themes since it changes a couple selectors.

#2 @lancewillett
13 years ago

  • Keywords early added
  • Milestone 3.6Future Release

Wow, this is more involved than I imagined. Let's bump to 3.7, too late for thorough testing before 3.6.

#3 @lancewillett
13 years ago

  • Milestone Future Release3.7

#4 @helen
13 years ago

  • Milestone 3.7Future Release

No signs of testing - move it back and commit it if you did, lance. :)

#5 @lancewillett
12 years ago

  • Keywords needs-refresh added; early removed
  • Milestone Future Release4.0

This ticket was mentioned in IRC in #wordpress-themes by obenland. View the logs.


12 years ago

#7 @obenland
12 years ago

  • Milestone 4.0Future Release

No movement, let's look at it after 4.0.

@jcastaneda
12 years ago

#8 @jcastaneda
12 years ago

Tested, modified a little to suit the way most of the other twenty* themes format as well. Ran into the issue of when you chose not to have the text and tried to re-enable the text would not reappear. As it turns out it was the $header.hide() that was the culprit.

Tried with a child theme and no errors.

#9 @DavidTheMachine
12 years ago

Applied patch to Rev 29493, and verified that postMessage works as advertised.

Version 0, edited 12 years ago by DavidTheMachine (next)

@DavidTheMachine
12 years ago

24128.2 applied relative to the root directory

#10 @jcastaneda
12 years ago

Yes, thank you for catching that.

This ticket was mentioned in Slack in #core-themes by lancewillett. View the logs.


11 years ago

#12 @jartes
11 years ago

Tested the patch and it seems the postMessage is working in the Customizer but I noticed that the padding-right applied by #branding .only-search + #access div ul rule is making the main menu smaller in smartphones: https://cloudup.com/iufYxgz6r01. Adding padding-right: 0 in the proper responsive rule will fix it.

#13 @lancewillett
11 years ago

@jartes Can you add a refreshed patch please?

#14 @lancewillett
11 years ago

  • Keywords needs-testing needs-refresh removed
  • Milestone Future Release4.2

Tested .4 patch and works as expected. Includes minor small-screen fix as mentioned by jartes -- adding a new rule for small screens solves it.

#15 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolutionfixed
  • Status newclosed

In 31971:

Twenty Eleven: add postMessage support for header_textcolor to improve the user experience in the Customizer.

Fixes #24128, props kovshenin, jcastaneda, and lancewillett.

Note: See TracTickets for help on using tickets.