WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #24136, comment 6


Ignore:
Timestamp:
04/20/13 21:53:21 (12 months ago)
Author:
adamsilverstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24136, comment 6

    initial v1  
    33also did a little testing and verified the origin of all the -1 you see in the code - the diff values are indeed one off the model index. 
    44 
    5  looks like jQuery UI slider reports leftmost position as 1 for two handled mode and 0 for one handled mode, the revisions code assumes left most position is 1 and behaves accordingly; since single handled mode returns left most as 0, it actually ADDS 1 to that value to keep it consistent with the two handled position. 
     5jQuery UI slider reports leftmost position as 1 for two handled mode and 0 for one handled mode, the revisions code assumes left most position is 1 and behaves accordingly; since single handled mode returns left most as 0, it actually ADDS 1 to that value to keep it consistent with the two handled position. 
    66 
    77it might be possible to change the stored value in the slider callbacks instead, but i'm nervous about changing/breaking what already works.