WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #24146, comment 26


Ignore:
Timestamp:
02/03/2026 03:52:59 PM (2 months ago)
Author:
ozgursar
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #24146, comment 26

    initial v1  
    11== Patch Testing Report
    22
    3 Patch Tested: https://core.trac.wordpress.org/attachment/ticket/24146/24146.3.diff
     3Patch Tested: https://github.com/WordPress/wordpress-develop/pull/7699
    44
    55=== Environment
    … …  
    25257. `Test2` gets removed as soon as menu is saved
    26268. Apply patch
    27 9. ❌ Patch is failing to apply.
     279. Add a new item to the menu as `test2 after patch`
     2810. Save the menu, check the homepage.
     2911. Delete the label of `test2 after patch` and save
     3012. Item remains on the menu with blank label.
     3113. Check the menu on the frontend and confirm that it works as `Untitled`
     3214.  ✅ Patch is solving the problem.
    2833
    29 === Additional Notes
    30 - When I tried to apply the patch agains the latest `trunk` (7.0-alpha-61215-src) it fails to apply with the following message and rejects:
    31 
    32 
    33 {{{
    34 Running "patch:24146" (patch) task
    35 ? Please select a patch to apply 24146.3.diff​ (2.0 KB) - added by vinod dalvi 9 years ago.
    36 patching file 'src/wp-admin/includes/nav-menu.php'
    37 1 out of 1 hunks failed--saving rejects to 'src/wp-admin/includes/nav-menu.php.rej'
    38 patching file 'src/wp-includes/nav-menu-template.php'
    39 patching file 'src/wp-includes/nav-menu.php'
    40 1 out of 1 hunks failed--saving rejects to 'src/wp-includes/nav-menu.php.rej'
    41 }}}
    42 
    43 Thus, I removed `needs-testing` and added `needs-refresh`
     34=== Expected result
     35- We expect the menu item to remain in the menu even after its label has been deleted. I can confirm that it stays in the menu and the anchor link becomes `Untitled`.
    4436
    4537=== Screenshots/Screencast with results
    46 Bug reproduction video: https://i.imgur.com/XFb0KkI.mp4
     38Video before patch: https://i.imgur.com/XFb0KkI.mp4
    4739
     40Video after patch: https://i.imgur.com/xccC16R.mp4
     41