Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24149 closed defect (bug) (fixed)

Set RTL body class for iframes

Reported by: mitchoyoshitaka's profile mitchoyoshitaka Owned by:
Milestone: 3.7 Priority: normal
Severity: minor Version:
Component: Administration Keywords: dev-feedback
Focuses: Cc:

Description

iframe_header() sets the current locale string in the body class, but not the RTL flag. Please add this.

This came up in MP6 development, where MP6 does not (at this moment) rely on a separate rtl stylesheet like in the current admin CSS, but instead relies more on the body having .rtl set.

Attachments (1)

24149.diff (649 bytes) - added by mitchoyoshitaka 11 years ago.
Patch

Download all attachments as: .zip

Change History (8)

@mitchoyoshitaka
11 years ago

Patch

#1 @SergeyBiryukov
11 years ago

  • Keywords commit 3.7-early added
  • Milestone changed from Awaiting Review to Future Release

#2 @wonderboymusic
11 years ago

  • Milestone changed from Future Release to 3.7

these are all marked 3.7-early

#3 @nacin
11 years ago

There is also wp_iframe() and probably a few other places where we have a <body> element and should also have a .rtl class.

editimage.html might be the one place where you won't be able to externally style.

#4 @ryan
11 years ago

In 24994:

Set RTL body class for iframes.

Props mitchoyoshitaka
see #24149

#5 @nacin
11 years ago

  • Keywords has-patch commit 3.7-early removed

Where else does it need to be added?

#6 @DrewAPicture
11 years ago

  • Keywords dev-feedback added

#7 @nacin
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Calling this as fixed pending further issues/needs.

Note: See TracTickets for help on using tickets.