WordPress.org

Make WordPress Core

Opened 15 months ago

Closed 5 months ago

#24170 closed enhancement (fixed)

oEmbed / Vimeo: Support player.vimeo.com-style URLs

Reported by: danielbachhuber Owned by: nacin
Milestone: 3.9 Priority: low
Severity: minor Version:
Component: Embeds Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

Vimeo also supports URLs like http://player.vimeo.com/video/64213430 for its oEmbed endpoint. It would be nice if the core regex also handled these URLs.

Attachments (1)

24170.1.diff (1.2 KB) - added by danielbachhuber 15 months ago.

Download all attachments as: .zip

Change History (8)

danielbachhuber15 months ago

comment:1 Ipstenu5 months ago

  • Keywords has-patch added

comment:2 Ipstenu5 months ago

player.vimeo is their old URL - http://vimeo.com/help/faq/sharing-videos/embedding-videos#can-i-embed-my-video-on-an-https-domain - How much is this used that it's still needed?

comment:3 danielbachhuber5 months ago

Sorry, I don't remember the original context in which this came up.

comment:4 nacin5 months ago

  • Keywords 2nd-opinion added
  • Milestone changed from Awaiting Review to Future Release

I don't know if they're still used, though they still work. http://player.vimeo.com/video/85152562.

If we can find them in use, we should support them. If they're no longer used, I don't think it's worth it.

comment:5 Ipstenu5 months ago

I found a handful of reports in the forums about this exact problem, so since Vimeo is phasing it out, I think it's a coin toss here :/ So few people appear to have this problem. I think we should patch it, since it's rare enough that if it does happen, the odds of someone recognizing why AND knowing the 'fix' is to use the non-player URL would be rarer.

comment:6 nacin5 months ago

  • Milestone changed from Future Release to 3.9

I didn't realize vimeo was already a regex. No harm in just allowing any subdomain.

comment:7 nacin5 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27225:

Allow any vimeo.com subdomain for embeds.

props danielbachhuber.
fixes #24170.

Note: See TracTickets for help on using tickets.