Trashing a page selected as "Page on Front" produces homepage 404

[danielbachhuber]

Steps to produce:

1. Create a new page called "My Home Page". Add some bacon ipsum.
2. Assign the page as your static home page.
3. Trash the page, but don't delete it.

Expected behavior: My homepage reverts to a list of my most recent posts

Actual behavior: 404 template is loaded.

In r6337, we started listing most recent posts when the page is deleted. However, there's a short circuit (added later) in wp_delete_post() to wp_trash_post(), which doesn't delete the option. This results in the homepage not being reset until the post is actually deleted.

I think the trashing behavior should be consistent with deleting behavior.

Related: #16379, #14403

[danielbachhuber]

24171.1.diff is a POC of what I think should be happening (and throwing the unstick_post() in there for good riddance).

[SergeyBiryukov]

Related: #23455

[c3mdigital]

Patch tested and works as intended.

[SergeyBiryukov]

#23455 was marked as a duplicate.

[nacin]

It sure would be nice if this was DRY with wp_delete_post().

[nacin]

I was going to commit this, then I thought about my comment — what about 24171.diff​?

[nacin]

In 25686:

Reset "Page on Front" when such a page is trashed.

props danielbachhuber.
fixes #24171.

[dlh]

#23455 was marked as a duplicate.