WordPress.org

Make WordPress Core

#24176 closed enhancement (fixed)

Twenty Thirteen: improve Quote post format styles to look more like quotes

Reported by: lancewillett Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-refresh
Focuses: Cc:

Description

Reported by MarkJaquith and Nacin, Quote post format styles could look more like quotes.

Example from Mark: http://cl.ly/image/3K22353h0K2j

There’s one thing that kind of seems off to me… the Quote format. It doesn’t seem very “Quote-y”. None of the traditional blockquote cues are used… indentation, quote marks, left-border… Same for source. No em-dash.

From Andy:

Also agree that quotes lack sufficient styling. This isn’t just designer’s license, this is an issue of things looking like they are plagiarized. (Someone else, a journalist, pointed this out to me at a meetup, and I forgot to relay it.) It needs to be clear that a quote is a quote.

CSS patch attached, provided by Joen. Here's what it should look like: http://cl.ly/image/3H2K3j2J1B3D

Joen notes:

These two add opening and closing curly quotes. CSS 3 actually has those builtin, i.e. content: open-quote; and content: close-quote;. But neither of those work in Chrome, hence the escaped glyphs.

Attachments (6)

24176.diff (570 bytes) - added by lancewillett 23 months ago.
quote-mockup-joen.png (89.4 KB) - added by lancewillett 23 months ago.
24176.2.diff (1.2 KB) - added by SergeyBiryukov 22 months ago.
24176.3.diff (680 bytes) - added by obenland 22 months ago.
Removes author bio from quote formats
quotes.png (38.0 KB) - added by lancewillett 22 months ago.
24176.4.diff (2.4 KB) - added by lancewillett 22 months ago.

Download all attachments as: .zip

Change History (22)

@lancewillett23 months ago

comment:1 @SergeyBiryukov23 months ago

This would need some i18n love.

  1. Many languages use different curly quotes (see #10001 and #19602 for related changes in core):
    http://en.wikipedia.org/wiki/Non-English_usage_of_quotation_marks
    We should use quotes from wptexturize():
    http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/formatting.php#L36
  2. 24176.diff assumes that full stop can always be included inside quotation marks. This convention is only valid for U.S. and Canada:
    http://en.wikipedia.org/wiki/Full_stop#Punctuation_styles_when_quoting
Version 0, edited 23 months ago by SergeyBiryukov (next)

@SergeyBiryukov22 months ago

comment:2 follow-up: @SergeyBiryukov22 months ago

I wonder if this should be a core patch instead. See 24176.2.diff as a starting point.

comment:3 @RDall22 months ago

  • Cc robert@… added

comment:4 in reply to: ↑ 2 @obenland22 months ago

Replying to SergeyBiryukov:

I wonder if this should be a core patch instead. See 24176.2.diff as a starting point.

I like that. What's with the period business though? :) I always thought the closing quote comes after the period in the quote, no?

comment:5 @lancewillett22 months ago

  • Cc nacin added

I think this should be theme-specific, it's a visual style and not markup-driven or content, right?

@nacin Thoughts?

comment:6 @lancewillett22 months ago

Discussing more in IRC during today's dev chat (log). I argued that the visual quote style should come from the theme, allowing authors to add their own punctuation if they wish—or themes can style as they see fit. Rather than adding curly quotes in the core markup output.

Howewer, the em-dash in the core markup is a good idea; it can wrapped in a filter to be disabled, and can be translatable.

For Twenty Thirteen:

  1. Quotes in post content already are visually separated: larger font size, italics, and indented.
  2. For Quote formats, where the quote stands alone ... we *could* explore visual techniques to make sure the quote looks "quotey" like an indent or bit of a background change. I'm leaning towards how it works now, though.
  3. The em-dash in front of the source will help a lot, for 2.

comment:7 @lancewillett22 months ago

  • Keywords needs-refresh added; needs-testing removed

See #24243 for the em-dash addition to the core markup output.

comment:8 follow-up: @markjaquith22 months ago

Can we kill the Author bio for quotes? We kind of have a Michael Scott situation going on:

http://25.media.tumblr.com/tumblr_lqiu1uOtc61r2or6qo1_500.jpg

@obenland22 months ago

Removes author bio from quote formats

comment:9 in reply to: ↑ 8 ; follow-up: @lancewillett22 months ago

Replying to markjaquith:

Can we kill the Author bio for quotes? We kind of have a Michael Scott situation going on:

I disagree on removing. We've discussed previously for various formats, but I believe we decided to leave them in for multi-user blogs. I'll research and see if I can find the context.

comment:10 in reply to: ↑ 9 @lancewillett22 months ago

Replying to lancewillett:

Replying to markjaquith:

Can we kill the Author bio for quotes? We kind of have a Michael Scott situation going on:

I disagree on removing. We've discussed previously for various formats, but I believe we decided to leave them in for multi-user blogs. I'll research and see if I can find the context.

OK, I couldn't find any such discussion. I must have gotten my wires crossed with the Chat post format—which is similar in that it's odd to have an author bio below a chat.

Thoughts on removing it for both Quote and Chat?

comment:11 @markjaquith22 months ago

Yep, I'd be good with removing it for both those formats, which are just pure quotes from other people.

comment:12 @lancewillett22 months ago

In 24167:

Twenty Thirteen: remove Author Bio from post formats that are essentially quotes from other people, like Quote and Chat. Props obenland and markjaquith -- see #24176.

comment:14 @lancewillett22 months ago

I'm working with Joen to get something cooked up for this. Aiming for decorative and left-hanging left curly quote mark—but also making sure it aligns with other post formats when viewed on an index page (the "flow" is important).

Note: the normal blockquote styles "in situ" in posts and pages—non-Quote post formats—will not change, as the existing styles work great in those cases.

@lancewillett22 months ago

comment:15 @lancewillett22 months ago

quotes.png is the direction Joen and I would like to try out for size. Nice balance between making it more obviously "quotey" and keeping in the flow of existing post formats.

@lancewillett22 months ago

comment:16 @lancewillett22 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24172:

Twenty Thirteen: improve Quote post format styles to look more like quotes. Fixes #24176.

Note: See TracTickets for help on using tickets.