Opened 12 years ago
Closed 12 years ago
#24176 closed enhancement (fixed)
Twenty Thirteen: improve Quote post format styles to look more like quotes
Reported by: | lancewillett | Owned by: | lancewillett |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch needs-refresh |
Focuses: | Cc: |
Description
Reported by MarkJaquith and Nacin, Quote post format styles could look more like quotes.
Example from Mark: http://cl.ly/image/3K22353h0K2j
There’s one thing that kind of seems off to me… the Quote format. It doesn’t seem very “Quote-y”. None of the traditional blockquote cues are used… indentation, quote marks, left-border… Same for source. No em-dash.
From Andy:
Also agree that quotes lack sufficient styling. This isn’t just designer’s license, this is an issue of things looking like they are plagiarized. (Someone else, a journalist, pointed this out to me at a meetup, and I forgot to relay it.) It needs to be clear that a quote is a quote.
CSS patch attached, provided by Joen. Here's what it should look like: http://cl.ly/image/3H2K3j2J1B3D
Joen notes:
These two add opening and closing curly quotes. CSS 3 actually has those builtin, i.e. content: open-quote; and content: close-quote;. But neither of those work in Chrome, hence the escaped glyphs.
Attachments (6)
Change History (22)
#1
@
12 years ago
#2
follow-up:
↓ 4
@
12 years ago
I wonder if this should be a core patch instead. See 24176.2.diff as a starting point.
#4
in reply to:
↑ 2
@
12 years ago
Replying to SergeyBiryukov:
I wonder if this should be a core patch instead. See 24176.2.diff as a starting point.
I like that. What's with the period business though? :) I always thought the closing quote comes after the period in the quote, no?
#5
@
12 years ago
- Cc nacin added
I think this should be theme-specific, it's a visual style and not markup-driven or content, right?
@nacin Thoughts?
#6
@
12 years ago
Discussing more in IRC during today's dev chat (log). I argued that the visual quote style should come from the theme, allowing authors to add their own punctuation if they wish—or themes can style as they see fit. Rather than adding curly quotes in the core markup output.
Howewer, the em-dash in the core markup is a good idea; it can wrapped in a filter to be disabled, and can be translatable.
For Twenty Thirteen:
- Quotes in post content already are visually separated: larger font size, italics, and indented.
- For Quote formats, where the quote stands alone ... we *could* explore visual techniques to make sure the quote looks "quotey" like an indent or bit of a background change. I'm leaning towards how it works now, though.
- The em-dash in front of the source will help a lot, for 2.
#7
@
12 years ago
- Keywords needs-refresh added; needs-testing removed
See #24243 for the em-dash addition to the core markup output.
#9
in reply to:
↑ 8
;
follow-up:
↓ 10
@
12 years ago
Replying to markjaquith:
Can we kill the Author bio for quotes? We kind of have a Michael Scott situation going on:
I disagree on removing. We've discussed previously for various formats, but I believe we decided to leave them in for multi-user blogs. I'll research and see if I can find the context.
#10
in reply to:
↑ 9
@
12 years ago
Replying to lancewillett:
Replying to markjaquith:
Can we kill the Author bio for quotes? We kind of have a Michael Scott situation going on:
I disagree on removing. We've discussed previously for various formats, but I believe we decided to leave them in for multi-user blogs. I'll research and see if I can find the context.
OK, I couldn't find any such discussion. I must have gotten my wires crossed with the Chat post format—which is similar in that it's odd to have an author bio below a chat.
Thoughts on removing it for both Quote and Chat?
#11
@
12 years ago
Yep, I'd be good with removing it for both those formats, which are just pure quotes from other people.
#13
@
12 years ago
Here's what I'm using:
https://gist.github.com/markjaquith/80147de2ab6f38b25597
Requires patch from #24243
#14
@
12 years ago
I'm working with Joen to get something cooked up for this. Aiming for decorative and left-hanging left curly quote mark—but also making sure it aligns with other post formats when viewed on an index page (the "flow" is important).
Note: the normal blockquote styles "in situ" in posts and pages—non-Quote post formats—will not change, as the existing styles work great in those cases.
This would need some i18n love.
http://en.wikipedia.org/wiki/Non-English_usage_of_quotation_marks
We should use quotes from
wptexturize()
:http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/formatting.php#L36
http://en.wikipedia.org/wiki/Full_stop#Punctuation_styles_when_quoting