MediaElement.js i18n issues

[SergeyBiryukov]

As reported by dimadin in #23282:

MedaElement.js has very poor i18n support that isn't compatible with one we use in WordPress since it relies on browser's language to determine locale, and strings are hardcoded in it (see ​pull that introduced this).

I looked how to improve this and have it backward compatible and attached patch contains my proposal. Note that this shouldn't go straight to WordPress since it contains changes to MedaElement.js too. I wanted to hear thoughts from others before submitting pull to MedaElement.js. When they add compatible support, we can patch WordPress.

Milan's patch from #23282

While we're at it, could we get ​http://mediaelementjs.com/ to spell WordPress correctly? :)

Can you make a patch for MEjs upstream so we can report here: ​https://github.com/johndyer/mediaelement/issues/new ?

24183.me.patch​ is a patch for MediaElement.js master branch.

24183.2.patch​ is a refreshed patch for script-loader.php.

Created a pull request: ​https://github.com/johndyer/mediaelement/issues/849

Pull request was accepted: ​https://github.com/johndyer/mediaelement/pull/850

Flash file of 2.12.0

CSS + JS of 2.12.0

MediaElement.js 2.12.0 was ​released.

In 24410:

Update MediaElement.js to 2.12.0. see #24183.

Refreshed and added missing strings

Through a change in ME, see ​https://github.com/johndyer/mediaelement/commit/68ce179cbd, the patch doesn't work.

Seems like we could just nest it one level further, maybe?

I do wonder, if mediaelement is already enqueued, how much 24183.diff​ could break the whole mejs object.

Replying to nacin:

Seems like we could just nest it one level further, maybe?

No, ME.js just overrides it. See ​https://github.com/johndyer/mediaelement/blob/master/build/mediaelement-and-player.js#L1676

So, the problem is that when MEjs tries to use mejs.i18n.locale.strings, the mejs.i18n object is already overwritten above with the one that doesn't contain the strings we're trying to add. It also doesn't detect the language we're trying to pass.

24183.me.2.patch​ is a patch for upstream that makes the most sense to me. It consults a separate mejsL10n object, which follows the pattern we have in script-loader.php.

24183.4.patch​ complements it on our side.

If we have to use it as-is, looks like will have to split mediaelement-and-player.js in two files. It has two parts: MediaElement.js at the top, MediaElementPlayer at the bottom. The translation needs to be between them to initialize properly.

With mediaelement-and-player.js being an official upstream build, I think we have a good chance of getting a pull request accepted.

(At worst, let's plan on monkey-patching until a PR is accepted.)

Created a new pull request: ​https://github.com/johndyer/mediaelement/pull/940

Replying to azaozz:

If we have to use it as-is, looks like will have to split mediaelement-and-player.js in two files.

24183.4.alt.patch​ implements that, just in case. Both mediaelement.min.js and mediaelementplayer.min.js are also official upstream builds.

Pull request was accepted. Once 2.12.1 is out, 24183.4.patch​ should be good to go.

Let's just sit tight for upstream then. By the end of the week, if there is no 2.12.1, we should merge in the patch ourselves.

In 24755:

Update MediaElement.js to include i18n fixes that were accepted upstream. Add strings to script-loader.

props SergeyBiryukov.
see #24183.

Leaving this open while we wait for 2.12.1.

In 24786:

Update MediaElement.js to a new 2.12.1 (untagged) build. see #24183.

Is there anything outstanding to do on this ticket?

It seems like [24786] breaks some things. See ​http://wordpress.org/support/topic/audio-player-controls-disappear-in-rc2.

Currently I only can reproduce it in Opera with a MP3 and MP4 file. Reverting to 24785 shows the controls again.

Replacing flashmediaelement.swf with the one from ​https://github.com/johndyer/mediaelement/commit/c52d79f0853567190d5a1607d82af0da6eacd66e restores the controls for me.

In 24861:

Update MediaElement.js SWF file from upstream. Fixes issues with controls. fixes #24183.

In 24862:

Update MediaElement.js SWF file from upstream. Fixes issues with controls. fixes #24183.

Merges [24861] to the 3.6 branch.

In 24910:

New build of MediaElement.js SWF. see #24183.

In 24911:

New build of MediaElement.js SWF. see #24183. For the 3.6 branch.

In 24946:

Update MediaElement.js to 2.13.0 build, which fixes issues WordPress reported. see #24183.

In 24947:

Update MediaElement.js to 2.13.0 build, which fixes issues WordPress reported. see #24183.

Merges [24946] to the 3.6 branch.