WordPress.org

Make WordPress Core

Opened 12 months ago

Closed 2 months ago

Last modified 2 months ago

#24189 closed defect (bug) (fixed)

{$taxonomy}_relationships cache can easily become stale when a term is updated.

Reported by: westi Owned by:
Milestone: 3.9 Priority: normal
Severity: major Version: 3.6
Component: Taxonomy Keywords: has-patch 3.7-early
Focuses: Cc:

Description

The {$taxonomy}_relationships cache stores the information about the terms associated with an object for a particular taxonomy.

If you update the term then we don't invalidate the cache and therefore a call to something like: get_the_terms() will return invalid data.

An example set of steps to reproduce (needs some form of persistent caching like memcache):

1) Create a new tag and assign it to a post
2) Use get_the_terms()
3) Edit the tag to change the description
4) Use get_the_terms() and find the old description is returned.

Very easy to reproduce in a unit-test.

Re-constituting the relationships cache for every object that is related to the term is probably going to be very expensive.

Maybe we should just switch to only caching IDs and then populating the term data from a different cache?

Attachments (1)

24189.diff (559 bytes) - added by westi 12 months ago.
Add a simple freshen of the term info during the get_object_term_cache call.

Download all attachments as: .zip

Change History (10)

comment:1 westi12 months ago

Added a test in [1272/tests]

westi12 months ago

Add a simple freshen of the term info during the get_object_term_cache call.

comment:2 mintindeed12 months ago

  • Cc gabriel.koen@… added

comment:4 nacin10 months ago

  • Keywords has-patch 3.7-early added
  • Milestone changed from 3.6 to Future Release
  • Priority changed from high to normal

Per IRC.

Last edited 10 months ago by DrewAPicture (previous) (diff)

comment:5 wonderboymusic9 months ago

  • Milestone changed from Future Release to 3.7

these are all marked 3.7-early

comment:6 nacin7 months ago

  • Milestone changed from 3.7 to Future Release

comment:7 nacin6 months ago

{$taxonomy}_children: #25711

comment:8 wonderboymusic2 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [27101].

comment:9 wonderboymusic2 months ago

  • Milestone changed from Future Release to 3.9
Note: See TracTickets for help on using tickets.