Make WordPress Core

Opened 13 years ago

Closed 12 years ago

#24194 closed defect (bug) (fixed)

Twenty Thirteen: non-responsive layout in IE8

Reported by: jrbeilke Owned by: phpmypython
Priority: normal Milestone: 4.1
Component: Bundled Theme Version: 3.6
Severity: normal Keywords: good-first-bug has-patch commit
Cc: Focuses: accessibility

Description

Testing Twenty Thirteen with 3.6 beta and I'm getting scrollbars when resizing the window in IE8 less than 1060px wide.

Attachments (2)

twentythirteen-ie8noresponsive.jpg (140.8 KB ) - added by jrbeilke 13 years ago.
Fixing_responsive_in_ie8.patch (624 bytes ) - added by phpmypython 12 years ago.
diff

Download all attachments as: .zip

Change History (15)

#1 follow-up: @RDall
13 years ago

  • Resolutioninvalid
  • Status newclosed

IE8 doesn't support media queries so it can't be responsive like the theme is in other browsers.

See here: http://caniuse.com/#feat=css-mediaqueries

#2 @SergeyBiryukov
13 years ago

  • Milestone Awaiting Review

#3 in reply to: ↑ 1 @whyameye
12 years ago

  • Resolution invalid
  • Status closedreopened

Replying to RDall:

IE8 doesn't support media queries so it can't be responsive like the theme is in other browsers.

See here: http://caniuse.com/#feat=css-mediaqueries

While IE8 does not support media queries out-of-the-box, it does appear that the theme is intended to work responsively in IE8, as it is responsive in IE6.

You can test this yourself in Browserstack by visiting:
http://twentythirteendemo.wordpress.com/

Last edited 12 years ago by whyameye (previous) (diff)

#4 @obenland
12 years ago

  • MilestoneAwaiting Review
  • Version3.6

#5 follow-up: @obenland
12 years ago

  • Keywords good-first-bug added
  • Milestone Awaiting ReviewFuture Release

It looks like it's caused by the very first style in css/ie.css. It was introduced with the initial commit.

As far as I can see, removing it shouldn't break too many things (IE7/8). A path would be trivial, but it should be tested thoroughly.

#6 in reply to: ↑ 5 @whyameye
12 years ago

Thanks for this feedback. So far, experimenting with commenting out the line you suggest fixes the problem without causing other problems. For now to solve this I've set up a child theme which loads in the alternative ie.css with the line commented out and prevents the original ie.css from being loaded.

Replying to obenland:

It looks like it's caused by the very first style in css/ie.css. It was introduced with the initial commit.

As far as I can see, removing it shouldn't break too many things (IE7/8). A path would be trivial, but it should be tested thoroughly.

#7 @phpmypython
12 years ago

  • Focuses accessibility added
  • Keywords has-patch added

That is the fix that needed to be added and i tested and got no problems in ie8.
Hopefully this is all that we need

#8 @obenland
12 years ago

  • Keywords needs-testing added

#9 @DrewAPicture
12 years ago

  • Owner set to phpmypython
  • Status reopenedassigned

#10 @lancewillett
12 years ago

  • Milestone Future Release4.1

Let's test the patch one more time and get this fix in for 4.1.

#11 @zrothauser
12 years ago

Tested and it's still working.

#12 @lancewillett
12 years ago

  • Keywords commit added; needs-testing removed

#13 @lancewillett
12 years ago

  • Resolutionfixed
  • Status assignedclosed

In 30386:

Twenty Thirteen: fix non-responsive layout in IE8. Props phpmypython, fixes #24194.

Note: See TracTickets for help on using tickets.