WordPress.org

Make WordPress Core

Opened 23 months ago

Closed 22 months ago

Last modified 22 months ago

#24213 closed defect (bug) (fixed)

Revisions: wp_list_post_revisions( format => 'form-table' ) is broken

Reported by: ocean90 Owned by: ocean90
Milestone: 3.6 Priority: high
Severity: normal Version: 3.6
Component: Revisions Keywords: has-patch
Focuses: Cc:

Description

Current state:

http://f.cl.ly/items/0l2O3F330f1T132k1L1W/Bildschirmfoto%202013-04-28%20um%2018.59.50.png

Since [23769].

The doc block includes "@todo split into two functions (list, form-table) ?"

Is the form table still needed and if yes should the new UI respond to the request?

Attachments (3)

post-template.php.patch (4.2 KB) - added by a.hoereth 22 months ago.
$format deprecated, removed 'form-table' conditional, re-indented rest
24213.patch (5.5 KB) - added by ocean90 22 months ago.
24213.2.patch (5.6 KB) - added by a.hoereth 22 months ago.
param string $type : 'all', 'revision' or 'autosave'; deprecated $args

Download all attachments as: .zip

Change History (11)

comment:1 follow-up: @SergeyBiryukov23 months ago

[23769] removed a big portion of previous UI in form-table mode (see wp-includes/post-template.php, lines 1405 to 1432).

I guess the remaining part should be removed as well. The format argument can be deprecated, as it's no longer used anywhere.

comment:2 in reply to: ↑ 1 @adamsilverstein22 months ago

Replying to SergeyBiryukov:

[23769] removed a big portion of previous UI in form-table mode (see wp-includes/post-template.php, lines 1405 to 1432).

I guess the remaining part should be removed as well. The format argument can be deprecated, as it's no longer used anywhere.

yes, this should be able to be safely removed

@a.hoereth22 months ago

$format deprecated, removed 'form-table' conditional, re-indented rest

comment:3 follow-up: @a.hoereth22 months ago

  • Cc a.hoereth added
  • Keywords has-patch needs-testing added; needs-patch removed

comment:4 in reply to: ↑ 3 @adamsilverstein22 months ago

Replying to a.hoereth:

thanks! post-template.php.patch​​ looks good: tested and list works as expected.

@ocean9022 months ago

comment:5 @ocean9022 months ago

24213.patch adds also left, right and parent to the deprecated check and updates inline docs.

Nacin proposed to remove the wp_parse_args()/extract() and check $args['parent'] etc directly.

@a.hoereth22 months ago

param string $type : 'all', 'revision' or 'autosave'; deprecated $args

comment:7 @ocean9022 months ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 24175:

Revisions: Mark deprecated arguments in wp_list_post_revisions().

  • Second argument is now a string, which controls the revision type
  • Back compat for $argstype?
  • Remove lines for the old form-table format, since it's now just a list

props a.hoereth. fixes #24213.

comment:8 @ocean9022 months ago

  • Keywords needs-testing removed
Note: See TracTickets for help on using tickets.