WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#24219 closed defect (bug) (invalid)

All post formats not available in PressThis

Reported by: danielbachhuber Owned by:
Milestone: Priority: high
Severity: major Version:
Component: Post Formats Keywords: has-patch commit
Focuses: Cc:

Description

When creating a new PressThis post with Twenty Thirteen active, only Standard, Link, and Video are available as post formats:

https://www.evernote.com/shard/s2/sh/112e7c92-76b8-4b68-a17f-b59ac5deaaf2/32cb568f188b328ae97f285b46e7ac3b

Yes, I do use PressThis.

Similarly, mobile apps respecting wp_getPostFormats in XML-RPC will only show the post formats available with get_theme_support( 'post-formats' )

I haven't been following all of the recent post format discussion, but get_theme_support( 'post-formats' ) should probably return all post formats unless the theme has explicitly identified which formats it supports. This is a different approach than what r24089 did, and I only see two other uses of get_theme_support( 'post-formats' ) in core, but it doesn't accommodate for plugin/theme use of get_theme_support( 'post-formats' ).

Attachments (3)

24219.patch (1.9 KB) - added by SergeyBiryukov 5 years ago.
24219.2.patch (2.7 KB) - added by kovshenin 5 years ago.
24219.3.patch (2.8 KB) - added by DrewAPicture 5 years ago.
inline comment fix

Download all attachments as: .zip

Change History (12)

#1 @mark-k
5 years ago

Probably it is the wrong place for that, but why should a user be blocked at all from creating an image post if the theme doesn't support it? tomorrow he might change the theme, so why limit him from adding this relevant meta information on post creation?

#2 @SergeyBiryukov
5 years ago

24219.patch follows the same approach as in [24089].

There's an ongoing discussion in #24109 about how we should handle post-formats and structured-post-formats declarations in general.

#3 @kovshenin
5 years ago

  • Keywords has-patch added

Tested 24219.patch, works for me.

#4 @danielbachhuber
5 years ago

The patch doesn't address the exact same issue in XML-RPC though.

@kovshenin
5 years ago

#5 @kovshenin
5 years ago

24219.2.patch addresses the XML-RPC response in addition to Sergey's patch.

@DrewAPicture
5 years ago

inline comment fix

#6 @DrewAPicture
5 years ago

24219.3.patch clarifies the XML-RPC inline comment since as @kovshenin noted below it, all formats are supported going forward. Works as expected for me.

#7 @SergeyBiryukov
5 years ago

  • Keywords commit added

#9 @markjaquith
4 years ago

  • Milestone 3.6 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Removing post formats UI from core: #24452

Note: See TracTickets for help on using tickets.