Opened 13 years ago
Closed 13 years ago
#24222 closed enhancement (fixed)
No need to define $matches when using preg_match and preg_match_all
| Reported by: | kovshenin | Owned by: | nacin |
|---|---|---|---|
| Priority: | low | Milestone: | 3.6 |
| Component: | General | Version: | |
| Severity: | minor | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
I noticed that some of the new code in 3.6, especially around post formats, defines an empty $matches variable when using preg_match and preg_match_all. This is not required and we don't do it in a lot of other places in core.
Attachments (1)
Change History (5)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Went through all the codebase in search of these (except external libraries), my findings are in 24222.diff.