WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#24223 closed defect (bug) (fixed)

Error message when updating theme refers to 'plugin'.

Reported by: araucaria Owned by: azaozz
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.3
Component: Themes Keywords: has-patch commit
Focuses: Cc:

Description

When updating a theme, the error message given when the theme package is broken refers to 'plugin' rather than 'theme':

An error occurred while updating Web Minimalist 200901: The package could not be installed. The plugin contains no files..

There's also an extra full stop at the end of the message.

Attachments (1)

24223.patch (3.3 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (5)

@SergeyBiryukov2 years ago

comment:1 @SergeyBiryukov2 years ago

  • Component changed from Warnings/Notices to Themes
  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 3.6
  • Severity changed from trivial to normal
  • Version changed from 3.5.1 to 3.3

Related: [19246]

comment:2 @DrewAPicture2 years ago

24223.patch looks pretty good to me. Would be nice to include some translator notes with those strings in a future ticket.

comment:3 @aaroncampbell2 years ago

  • Keywords commit added; needs-testing removed

24223.patch looks good to me.

comment:4 @azaozz2 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 24313:

Add more specific error messages when upgrading themes and plugins and the package cannot be extracted (no files), props SergeyBiryukov, fixes #24223

Note: See TracTickets for help on using tickets.