WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#24229 closed defect (bug) (fixed)

Something is probably missing in post-template.php:1424

Reported by: settle Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: I18N Keywords: has-patch
Focuses: Cc:

Description (last modified by ocean90)

It seems %2$s should also be here:

	/* translators: post revision: 1: when, 2: author name */
	$titlef = _x( '%1$s', 'post revision' );

Attachments (2)

24229.diff (478 bytes) - added by DrewAPicture 2 years ago.
24229.2.diff (714 bytes) - added by DrewAPicture 2 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 @settle2 years ago

  • Version set to trunk

comment:2 @ocean902 years ago

  • Description modified (diff)
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.6

Since [23769].

Related: #24213

@DrewAPicture2 years ago

comment:3 @DrewAPicture2 years ago

If this was just a case of forgetting to remove the second translator note, 24229.diff takes care of that.

I'm confused about whether this ticket calls for adding $name back or fixing the translator comment.

comment:4 follow-up: @settle2 years ago

If only %1$s stays - there is no point to "translate" it at all.

@DrewAPicture2 years ago

comment:5 in reply to: ↑ 4 @DrewAPicture2 years ago

Replying to settle:

If only %1$s stays - there is no point to "translate" it at all.

Good call, wasn't thinking clearly. 24229.2.diff

comment:6 @SergeyBiryukov2 years ago

  • Keywords has-patch added; needs-patch removed

comment:7 @SergeyBiryukov2 years ago

Introduced in [23769].

comment:8 @SergeyBiryukov2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 24150:

Don't translate a single placeholder. Remove unused variables. props settle, DrewAPicture. fixes #24229.

Note: See TracTickets for help on using tickets.