Make WordPress Core

Opened 13 years ago

Last modified 6 weeks ago

#24241 new enhancement

Whitelist trackbacks/pingbacks from own site

Reported by: eurello's profile eurello Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.5.1
Component: Pings/Trackbacks Keywords: has-patch needs-testing has-unit-tests needs-refresh
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Currently, if a user has only "Comment author must have a previously approved comment" selected in Settings->Discussion, pingbacks from their own blog are still held for moderation every time. Users would expect that, given those discussion settings, once they'd approved one self-ping, all future self-pings would appear without requiring moderation.

There is a past ticket about this here: #999

Attachments (2)

24241.patch (1.3 KB) - added by stevegrunwell 11 years ago.
If a pingback or trackback is coming from a domain that already submitted an approved comment (of that type) will be automatically approved.
24241.diff (7.3 KB) - added by stevegrunwell 10 years ago.
Refreshed patch that properly prepares SQL queries, has unit tests, and better adheres to the WordPress coding standards.

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
13 years ago

  • Description modified (diff)

#2 @SergeyBiryukov
13 years ago

  • Component changed from General to Pings/Trackbacks

@stevegrunwell
11 years ago

If a pingback or trackback is coming from a domain that already submitted an approved comment (of that type) will be automatically approved.

#3 @stevegrunwell
11 years ago

  • Keywords has-patch needs-testing needs-unit-tests added

#4 @chriscct7
10 years ago

  • Type changed from defect (bug) to enhancement

@stevegrunwell
10 years ago

Refreshed patch that properly prepares SQL queries, has unit tests, and better adheres to the WordPress coding standards.

#5 @stevegrunwell
10 years ago

  • Keywords has-unit-tests added; needs-unit-tests removed

#6 @avcascade
10 years ago

Would love to see this enhancement make it into 4.5. It'd be nice to stop having to approve self-pings.

#7 @dshanske
10 years ago

Just wondering, considering that unlike outside sites, if the goal of this is self-pings, if there is a way to do it that doesn't involve a query like this by having a filter that accepts self-pings by default and can be disabled with a simple line of code added?

#8 @dshanske
10 years ago

  • Keywords needs-refresh added

WP_Comment_Query now supports author_url as a parameter. As there are advantages to using the Comment_Query class over direct SQL, suggesting we refresh the patch with that.

#9 @desrosj
7 months ago

  • Milestone set to Awaiting Review

I came to express a different opinion for this one.

Personally, I delete all pingbacks from my own site because I do not want the internal references to drown out comments from external sources or visitors. Instead, I make use of "related posts" to list related contents.

That said, I agree that it's a bit strange that the same site is not considered "trusted" or having pre-approved comments. Personally I would like a way to say "allow pingbacks/trackbacks, but not from my own site."

This ticket was mentioned in Slack in #core-test by mohkatz. View the logs.


3 months ago

#11 @desrosj
6 weeks ago

Related: #65016

#12 @dshanske
6 weeks ago

I withdrew as Pingback maintainer years ago, as I switched to a successor protocol, webmention, but as similar, still think about this. For webmentions, we did add an option to allow self pings or discard them. That might work here, even if it is a filter not a setting that controls it.

Note: See TracTickets for help on using tickets.