Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#24242 closed enhancement (fixed)

Rdio and Spotify oEmbed Support

Reported by: ryan's profile ryan Owned by: ryan's profile ryan
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Embeds Keywords:
Focuses: Cc:

Description (last modified by nacin)

With the addition of an Audio Post Format UI, rounding out our default oEmbed provider list with Rdio and Spotify support seems useful.

Attachments (3)

24242.diff (970 bytes) - added by ryan 11 years ago.
remove-hash.diff (970 bytes) - added by zekeweeks 11 years ago.
24242.2.diff (970 bytes) - added by ryan 11 years ago.
Use # instead of ! for regex delimiter to match others in provider list

Download all attachments as: .zip

Change History (13)

@ryan
11 years ago

#1 @ryan
11 years ago

Those regexes have been on wordpress.com for a long while.

#2 @zekeweeks
11 years ago

Tested out ryan's patch and I noticed that for long rdio.com URLs, the regex uses the old hashed URLs. Rdio currently serves non-hashed URLs such as http://www.rdio.com/artist/Kanye_West/album/Graduation/track/Can%27t_Tell_Me_Nothing/ . I tried removing the #/ and it looks like it works with both hashed and unhashed Rdio song URLs.

@ryan
11 years ago

Use # instead of ! for regex delimiter to match others in provider list

#3 @ryan
11 years ago

  • Milestone changed from Awaiting Review to 3.6

#4 @ryan
11 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 24160:

Add Rdio to the default oembed providers list.

Props zekeweeks
fixes #24242

#5 @nacin
11 years ago

  • Description modified (diff)
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from Rdio oEmbed Support to Rdio and Spotify oEmbed Support

24 hours ago, Spotify didn't have an oEmbed endpoint. They do now — https://twitter.com/nicklas2k/status/330094611202723840. Nice!

#6 @nacin
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 24164:

Add Spotify to the default oEmbed providers list. fixes #24242.

#7 @nacin
11 years ago

In 24165:

Support Spotify web player links. see #24242.

#9 @rovo89
11 years ago

I know it's just a tiny little detail, but I think the regex should be
#https?://(open|play)\.spotify\.com/.*#i
instead of
#https?://(open|play).spotify.com/.*#i

#10 @nacin
11 years ago

In 24168:

Escape periods in oEmbed regex. props rovo89. fixes #24242.

Note: See TracTickets for help on using tickets.