Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24243 closed defect (bug) (fixed)

Quote post format: prepend em-dash to quote source

Reported by: lancewillett's profile lancewillett Owned by: markjaquith's profile markjaquith
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Post Formats Keywords: has-patch commit
Focuses: Cc:



Goal: add a translatable em-dash before the Quote "source" output. Possibly filter it so themes or plugins could remove it.

Reasoning: provides a visual consistent (and mostly universal) indicator that the content is cited from an external source. Supports and enhances the "Quote" content type stored in this post format.

Attachments (3)

24243.diff (648 bytes) - added by lancewillett 11 years ago.
24243.1.diff (997 bytes) - added by lancewillett 11 years ago.
24243.2.diff (1.1 KB) - added by markjaquith 11 years ago.

Download all attachments as: .zip

Change History (8)

11 years ago

#1 @lancewillett
11 years ago

  • Keywords has-patch added; needs-patch removed

Patch (props SergeyBiryukov for the start) adds em-dash and non-breaking space before the source quote, with a filter so themes or plugins can change or remove.

#2 @lancewillett
11 years ago

.1 adds PHPDoc comment for the new filter.

11 years ago

#3 @markjaquith
11 years ago

.2.diff is a different approach, whereby the string format can be completely changed. Moved the non-breaking space inside of that.

#4 @lancewillett
11 years ago

  • Keywords commit added

+1 to filtering the space as well. I realized that after some more testing. I personally prefer no space, so I'd be filtering it out, heh.

#5 @markjaquith
11 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 24170:

Add a 'quote_source_format' filter and make the default an em-dash and a space preceding the source.

fixes #24243

Note: See TracTickets for help on using tickets.