Windows Phones are ignored by wp_is_mobile

[Ipstenu]

Reported in the forums by vaibhav3 - ​http://wordpress.org/support/topic/wp_is_mobile-returning-false-values/

wp_is_mobile() doesn't have an 'If Windows Phone' clause which throws off some phones which apparently don't have a 'mobile' fall back.

Attached is a patch that adds it in.

[Ipstenu]

Add windows phone to ismobile check

[johnbillion]

The touch features of the admin UI will need to be tested in WinPho if we add this in. I know that WinPho 7 had some peculiarities with touch events which would need testing.

[kraftner]

The check works and does recognize my Windows Phone 7.5.

My question is what needs to be checked to make it okay to have Windows Phone included?

Further I think that even if it doesnt work perfectly it might still be better than being on the "desktop" version.

[johnbillion]

24252.2.diff​ is just Ipstenu's patch updated with correct path for src.

The reason Windows Phone isn't currently included in is_mobile() is due to odd behaviour in the admin area in Windows Phone 7 when it was treated as a mobile device (some discussion on #20614).

Here's a list of things that'll need to be tested in the admin area using Windows Phone 7 and 8 in order to get this patch in:

• Viewport width on the login screen and general admin screens
• Access to controls in the admin area which only appear on hover for desktop devices, for example the action links on post listing screens (and Comments screen, Users screen, etc)
• Using the rich editor (TinyMCE)
• Adding and reordering items on the Widgets screen and the Menus screen

Hands up who has access to a Windows Phone device they can try this with? (With the patch applied of course.)

[atomicjack]

Related: #33704

[atomicjack]

Replying to johnbillion:

24252.2.diff​ is just Ipstenu's patch updated with correct path for src.

The reason Windows Phone isn't currently included in is_mobile() is due to odd behaviour in the admin area in Windows Phone 7 when it was treated as a mobile device (some discussion on #20614).

Here's a list of things that'll need to be tested in the admin area using Windows Phone 7 and 8 in order to get this patch in:

• Viewport width on the login screen and general admin screens
• Access to controls in the admin area which only appear on hover for desktop devices, for example the action links on post listing screens (and Comments screen, Users screen, etc)
• Using the rich editor (TinyMCE)
• Adding and reordering items on the Widgets screen and the Menus screen

Hands up who has access to a Windows Phone device they can try this with? (With the patch applied of course.)

I can definitely try this out on Windows 10 Mobile.

[johnbillion]

I'm going to wontfix this based on #33704 (removing reliance on wp_is_mobile()) and [40907] (introduce a filter on the return value of the function).