Make WordPress Core

Opened 11 years ago

Closed 7 years ago

#24252 closed enhancement (wontfix)

Windows Phones are ignored by wp_is_mobile

Reported by: ipstenu's profile Ipstenu Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch needs-testing
Focuses: Cc:

Description

Reported in the forums by vaibhav3 - http://wordpress.org/support/topic/wp_is_mobile-returning-false-values/

wp_is_mobile() doesn't have an 'If Windows Phone' clause which throws off some phones which apparently don't have a 'mobile' fall back.

Attached is a patch that adds it in.

Attachments (2)

24252.diff (689 bytes) - added by Ipstenu 11 years ago.
Add windows phone to ismobile check
24252.2.diff (671 bytes) - added by johnbillion 10 years ago.

Download all attachments as: .zip

Change History (12)

@Ipstenu
11 years ago

Add windows phone to ismobile check

#1 @johnbillion
11 years ago

The touch features of the admin UI will need to be tested in WinPho if we add this in. I know that WinPho 7 had some peculiarities with touch events which would need testing.

#2 @SergeyBiryukov
11 years ago

  • Component changed from Appearance to Administration

#3 @SergeyBiryukov
11 years ago

  • Keywords needs-testing added

#4 @kraftner
11 years ago

The check works and does recognize my Windows Phone 7.5.

My question is what needs to be checked to make it okay to have Windows Phone included?

Further I think that even if it doesnt work perfectly it might still be better than being on the "desktop" version.

#5 @ocean90
10 years ago

  • Component changed from Administration to General

#6 @wonderboymusic
10 years ago

  • Milestone changed from Awaiting Review to 4.0

@johnbillion
10 years ago

#7 follow-up: @johnbillion
10 years ago

  • Milestone changed from 4.0 to Future Release

24252.2.diff is just Ipstenu's patch updated with correct path for src.

The reason Windows Phone isn't currently included in is_mobile() is due to odd behaviour in the admin area in Windows Phone 7 when it was treated as a mobile device (some discussion on #20614).

Here's a list of things that'll need to be tested in the admin area using Windows Phone 7 and 8 in order to get this patch in:

  • Viewport width on the login screen and general admin screens
  • Access to controls in the admin area which only appear on hover for desktop devices, for example the action links on post listing screens (and Comments screen, Users screen, etc)
  • Using the rich editor (TinyMCE)
  • Adding and reordering items on the Widgets screen and the Menus screen

Hands up who has access to a Windows Phone device they can try this with? (With the patch applied of course.)

#9 in reply to: ↑ 7 @atomicjack
9 years ago

Replying to johnbillion:

24252.2.diff is just Ipstenu's patch updated with correct path for src.

The reason Windows Phone isn't currently included in is_mobile() is due to odd behaviour in the admin area in Windows Phone 7 when it was treated as a mobile device (some discussion on #20614).

Here's a list of things that'll need to be tested in the admin area using Windows Phone 7 and 8 in order to get this patch in:

  • Viewport width on the login screen and general admin screens
  • Access to controls in the admin area which only appear on hover for desktop devices, for example the action links on post listing screens (and Comments screen, Users screen, etc)
  • Using the rich editor (TinyMCE)
  • Adding and reordering items on the Widgets screen and the Menus screen

Hands up who has access to a Windows Phone device they can try this with? (With the patch applied of course.)

I can definitely try this out on Windows 10 Mobile.

#10 @johnbillion
7 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I'm going to wontfix this based on #33704 (removing reliance on wp_is_mobile()) and [40907] (introduce a filter on the return value of the function).

Note: See TracTickets for help on using tickets.