is_attachment() should accept $attachment parameter

[alex-ye]

Like is_single(),is_page(),is_author() ... etc I can't see any reason why we is_attachment() function accept $attachment parameter to make easy checks.

[wonderboymusic]

You aren't checking the post_type - nothing about that function is attachment-specific, it could evaluate true against an arbitrarily-passed post

[alex-ye]

Replying to wonderboymusic:

You aren't checking the post_type - nothing about that function is attachment-specific, it could evaluate true against an arbitrarily-passed post

I just make the patch like the is_page() function, We doesn't need to check the post-type since we pass an attachment ID, title, slug, or array of such.. so we don't need to check the Post object too.

You didn't give a reasons why the core doesn't add $attachment parameter.

[toscho]

Replying to wonderboymusic:

You aren't checking the post_type - nothing about that function is attachment-specific, it could evaluate true against an arbitrarily-passed post

The check for $this->is_attachment does exactly this. How could that return TRUE for another post type?

[wonderboymusic]

touche

[alex-ye]

can we put this in WordPress 3.7 ?

[wonderboymusic]

24257.diff​​ refreshes and adds Unit Tests

[wonderboymusic]

In 27016:

Let is_attachment() accept an $attachment parameter, similar to is_page() and is_single(). Adds Unit Tests for all 3.

Props alex-ye for the initial patch.
Fixes #24257.

[nacin]

I think this is solid. Could we add some assertions that also assert false? Just to make sure we don't have problems in the future. It might be nice to further assert things like $query->is_single/is_page/is_attachment (the property, not the methods), that the queried object matches the post that was created, etc.

Additionally, note that attachments are also is_single except in a single situation where it is instead is_page. It would be good to test is_singular(), is_singular and the respective is_(post|page) (methods and properties) in both truthiness and falseness.

[wonderboymusic]

In 27187:

Add some more assertions to Tests_Query_Conditionals, specifically for is_single(), is_page(), and is_attachment().

See [27016].
Fixes #24257.