Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #24258, comment 7


Ignore:
Timestamp:
05/07/2013 10:49:14 AM (13 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24258, comment 7

    initial v1  
    11See the combined patch in #23154.
    22
    3 `if ( empty( $post ) )` check from [attachment:24258.diff] probably makes sense, but it should return a string instead of null to be in line with the function's PHPDocs, and should be consistent with other `get_*_link()` functions, so it's better to address that in a separate ticket.
     3`if ( empty( $post ) )` check in `get_attachment_link()` from [attachment:24258.diff] probably makes sense, but it should return a string instead of null to be in line with the function's PHPDocs, and should be consistent with other `get_*_link()` functions, so it's better to address that in a separate ticket.