WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#24267 closed defect (bug) (duplicate)

JavaScript Syntax Error

Reported by: 1994rstefan Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

If you user HTML-Comments to hide JavaScript for browsers that do not support JavaScript, the closing HTML-Comment-Tag have to be a JavaScript-Comment

So instead of this Code:
<script type="text/javascript">
<!--
[some JavaScript]
-->
</script>
You should use
<script type="text/javascript">
<!--
[some JavaScript]
-->
</script>
Otherwise some Browsers will fail because of invalid JavaScript.
This is also descriped on w3schools (http://www.w3schools.com/tags/tag_comment.asp)

This error can be found in:
wp-includes/file.php on line 980
wp-includes/media.php on line 2075

Change History (3)

#1 @1994rstefan
4 years ago

Sorry, the Wiki escapes a double slash, it should say (without space):

<script type="text/javascript">
<!--
[some JavaScript]
/ / -->
</script>

Version 0, edited 4 years ago by 1994rstefan (next)

#2 @ocean90
4 years ago

  • Keywords needs-patch removed
  • Milestone Awaiting Review deleted
  • Status changed from new to closed

No, it's valid.

Duplicate: #23952

Related: #18788

#3 @ocean90
4 years ago

  • Resolution set to duplicate
Note: See TracTickets for help on using tickets.