Twenty Thirteen: .reply styling bleeding into other styles

[johnjamesjacoby]

The .reply styling in TwentyThirteen assumes that comments are the only dom elements that will ever have the 'reply' class. This is true in WordPress core, but plugins (like BuddyPress and bbPress) use the 'reply' class for activity stream items, topics, etc...

We're used to fixing this in our own theme compatibility layers, and arguably some responsibility falls on us for using less ambiguous class names or more strict CSS, but in the case of .reply, I think there exists at least some possibility that other plugins might be using the same class (shopping carts, reviews, polls, etc...) and experience similar styling intersections.

I've attached a patch that adds .comment-list before .reply to limit the scope of the style to the intended comments replies, for your consideration.

[lancewillett]

Thanks for the report and patch. +1 for making it the selectors a bit more specific.

[lancewillett]

Oops, @johnjamesjacoby could you make your patch from WP root?

[lancewillett]

.1 adds a few missing cases in style.css and a bit of cleanup for non .reply selectors.

[lancewillett]

In 24193:

Twenty Thirteen: more specificity for .reply selectors, props johnjamesjacoby for starter patch. Fixes #24268.

[johnjamesjacoby]

Thanks Lance for picking up my slack!