Post Formats: get_post_gallery() can return an array when asked for a string

[kovshenin]

If the requested post is not found or does not contain a gallery shortcode, get_post_gallery returns an empty array, regardless of what the $html argument is set to.

[kovshenin]

Sorry, blamed the wrong function :) get_post_gallery is the one and 24270.2.diff​ is the fix.

// The 9212 post has a gallery shortcode
echo gettype( get_post_gallery( 9212, false ) ); // array
echo gettype( get_post_gallery( 1, false ) ); // array
echo gettype( get_post_gallery( 9212, true ) ); // string
echo gettype( get_post_gallery( 1, true ) ); // array oO!

[kovshenin]

#24390 was marked as a duplicate.

[kovshenin]

The newer patch in #24390 applies cleanly.

[wonderboymusic]

my new patch applies cleanly and handles both cases 24270.3.diff​

[ocean90]

I think that get_content_images() and get_content_galleries() should mention that $html is the type inside the array, which will be returned and isn't the same as for get_post_gallery().

[markjaquith]

In 24572:

Make sure get_post_gallery() doesn't ever return an array when asked for a string.

props kovshenin, wonderboymusic, ocean90. fixes #24270.