WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24282 closed defect (bug) (fixed)

missing semicolon

Reported by: jcastaneda's profile jcastaneda Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 3.6 Priority: lowest
Severity: trivial Version: 3.4
Component: Customize Keywords:
Focuses: Cc:

Description

A missing semicolon in line 387 could cause some issues down the road. Added some spacing for readability

Attachments (1)

class-wp-customize-control.php.patch​ (2.9 KB) - added by jcastaneda 11 years ago.

Download all attachments as: .zip

Change History (4)

@jcastaneda
11 years ago

#1 @SergeyBiryukov
11 years ago

  • Component changed from General to Appearance

#2 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 3.6
  • Priority changed from normal to lowest
  • Severity changed from normal to trivial

While a semicolon should be there, it's not really an issue if it's missing. There are a lot of them missing in list tables and some older code too.

Coding style fixes should only be done in closely surrounding code, otherwise they can make patches with more substantial changes stale. Formatting cleanup tickets are generally discouraged:
​http://wpdevel.wordpress.com/2011/03/23/code-refactoring/.

#3 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 24200:

Add missing semicolon. props jcastaneda. fixes #24282.

Note: See TracTickets for help on using tickets.