WordPress.org

Make WordPress Core

#24286 closed defect (bug) (fixed)

Twenty Thirteen: Awaiting moderation notice styling

Reported by: SergeyBiryukov Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Awaiting moderation notice looks weird (see the screenshot).

Also, in RTL we switch :before and :after, so the sign ends up after the message. I don't think we should do that, text direction appears to take care of the correct positioning automatically. We should only fix floating and margins. Noticed that we currently do the same for other elements too. This should be reconsidered in #23550 or a new ticket.

Attachments (3)

24286.png (30.2 KB) - added by SergeyBiryukov 12 months ago.
24286.patch (1.1 KB) - added by SergeyBiryukov 12 months ago.
24286.after.png (30.1 KB) - added by SergeyBiryukov 12 months ago.

Download all attachments as: .zip

Change History (6)

SergeyBiryukov12 months ago

SergeyBiryukov12 months ago

SergeyBiryukov12 months ago

comment:1 lancewillett12 months ago

Thanks for the report, good patch for fixing the spacing of the moderation message.

The RTL and :before/:after needs investigation. I think in a few cases there aren't Genericons for RTL use, so it does need to be changed to the opposite. For example, for the Reply genericon we would need an arrow that points in the other direction.

comment:2 lancewillett12 months ago

#24287 for the RTL and Genericon audit.

comment:3 lancewillett12 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24202:

Twenty Thirteen: fix styling for comment moderation notice. Props SergeyBiryukov, fixes #24286.

Note: See TracTickets for help on using tickets.