Opened 12 years ago
Closed 12 years ago
#24287 closed defect (bug) (fixed)
Twenty Thirteen: evaluate Genericons and RTL support
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | rtl-feedback needs-patch |
Focuses: | Cc: |
Description
Check each Genericon and its support in the RTL stylesheet and evaluate if we need to switch the :before
to :after
or if a flipped icon is needed.
From SergeyBiryukov in #24286:
Also, in RTL we switch :before and :after, so the sign ends up after the message. I don't think we should do that, text direction appears to take care of the correct positioning automatically. We should only fix floating and margins.
Attachments (3)
Change History (11)
#2
in reply to:
↑ 1
@
12 years ago
Replying to SergeyBiryukov:
Switching both
:before
/:after
andmargin-left
/margin-right
results in mixed up margins.
See ticket:24286:24286.png, the grey awaiting moderation message on the right side. The sign should be on the right with left margin, not on the left with left margin.
Yep, have a fix for that almost ready based on your patch in #24286 -- but need to also remove the selector from the big list of Genericon handling.
#3
@
12 years ago
I think Comment Reply needs a flipped version alternate glyph in Genericons, so it can stay before.
#4
@
12 years ago
- Keywords needs-patch added; 2nd-opinion removed
Joen is now working on a full set of flipped arrows and other icons that need a mirrored version for RTL (or other uses).
Once it's ready, I'll update the font files in Twenty Thirteen and we can start applying them to RTL stylesheet case by case.
#5
@
12 years ago
.1 removes all the unneeded rules from RTL stylesheet, and some minor spacing fixes.
#6
@
12 years ago
Duh. We are already flipping the Audio Genericon glyph with transform
: http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentythirteen/rtl.css#L341
We can use that exact technique for the comment-reply icon.
Thanks to ipstenu, sabreuse, trepmal, and Joen for pointing that out:
https://twitter.com/ipstenu/statuses/332562276609576962
Switching both
:before
/:after
andmargin-left
/margin-right
results in mixed up margins.See ticket:24286:24286.png, the grey awaiting moderation message on the right side. The sign should be on the right with left margin, not on the left with left margin.