WordPress.org

Make WordPress Core

#24287 closed defect (bug) (fixed)

Twenty Thirteen: evaluate Genericons and RTL support

Reported by: lancewillett Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: rtl-feedback needs-patch
Focuses: Cc:

Description

Check each Genericon and its support in the RTL stylesheet and evaluate if we need to switch the :before to :after or if a flipped icon is needed.

From SergeyBiryukov in #24286:

Also, in RTL we switch :before and :after, so the sign ends up after the message. I don't think we should do that, text direction appears to take care of the correct positioning automatically. We should only fix floating and margins.

Attachments (3)

24287.diff (811 bytes) - added by lancewillett 12 months ago.
Fix comment moderation layout, props SergeyBiryukov
24287.1.diff (5.8 KB) - added by lancewillett 12 months ago.
24287.2.diff (6.4 KB) - added by lancewillett 12 months ago.

Download all attachments as: .zip

Change History (11)

comment:1 follow-up: SergeyBiryukov12 months ago

Switching both :before/:after and margin-left/margin-right results in mixed up margins.

See ticket:24286:24286.png, the grey awaiting moderation message on the right side. The sign should be on the right with left margin, not on the left with left margin.

comment:2 in reply to: ↑ 1 lancewillett12 months ago

Replying to SergeyBiryukov:

Switching both :before/:after and margin-left/margin-right results in mixed up margins.

See ticket:24286:24286.png, the grey awaiting moderation message on the right side. The sign should be on the right with left margin, not on the left with left margin.

Yep, have a fix for that almost ready based on your patch in #24286 -- but need to also remove the selector from the big list of Genericon handling.

lancewillett12 months ago

Fix comment moderation layout, props SergeyBiryukov

comment:3 lancewillett12 months ago

I think Comment Reply needs a flipped version alternate glyph in Genericons, so it can stay before.

comment:4 lancewillett12 months ago

  • Keywords needs-patch added; 2nd-opinion removed

Joen is now working on a full set of flipped arrows and other icons that need a mirrored version for RTL (or other uses).

Once it's ready, I'll update the font files in Twenty Thirteen and we can start applying them to RTL stylesheet case by case.

lancewillett12 months ago

comment:5 lancewillett12 months ago

.1 removes all the unneeded rules from RTL stylesheet, and some minor spacing fixes.

comment:6 lancewillett12 months ago

Duh. We are already flipping the Audio Genericon glyph with transform: http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentythirteen/rtl.css#L341

We can use that exact technique for the comment-reply icon.

Thanks to ipstenu, sabreuse, trepmal, and Joen for pointing that out:
https://twitter.com/ipstenu/statuses/332562276609576962

lancewillett12 months ago

comment:7 lancewillett12 months ago

.2 moves IE7 and IE8 styles to ie.css (for transforms) and adds -ms-transform prefix for IE9. Adds horizontal flip rules for comment reply.

comment:8 lancewillett12 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24223:

Twenty Thirteen: clean up RTL and Genericons styles. Props SergeyBiryukov for the comment moderation bits, fixes #24287.

Note: See TracTickets for help on using tickets.