WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#24296 closed defect (bug) (fixed)

Viddler oembed has new endpoint, old one strips maxwidth

Reported by: Otto42 Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description

Viddler changed their oembed endpoint:

http://developers.viddler.com/documentation/oembed/

Now it's "http://www.viddler.com/oembed/" instead of "http://lab.viddler.com/services/oembed/".

They have the old endpoint redirecting, but unfortunately, the redirection strips off the maxwidth (and possibly other) parameters, which can result in incorrectly sized videos when using oembed with Viddler.

Example:
http://lab.viddler.com/services/oembed/?url=http://www.viddler.com/v/bdce8c7&format=json&maxwidth=250

Redirects to:
http://www.viddler.com/oembed/?url=http://www.viddler.com/v/bdce8c7&format=json

We should change the endpoint in class-oembed.php to the new one. If the new endpoint is used directly, with no redirect, then it does correctly handle the maxwidth parameter.

Attachments (1)

24296.diff (1.2 KB) - added by garhdez 6 years ago.
Changed endpoint for Viddler oEmbed service

Download all attachments as: .zip

Change History (5)

@garhdez
6 years ago

Changed endpoint for Viddler oEmbed service

#1 @garhdez
6 years ago

Just changed the endpoint for the Viddler oEmbed API.

#2 @garhdez
6 years ago

  • Keywords has-patch added

#3 @johnbillion
5 years ago

  • Milestone changed from Awaiting Review to 4.0

#4 @wonderboymusic
5 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 28556:

Viddler has had a new oEmbed endpoint for at least 10 months. Let us update to it.

Props garhdez.
Fixes #24296.

Note: See TracTickets for help on using tickets.