WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#24303 closed defect (bug) (fixed)

Cite correct hook in _post_formats_fix_empty_title() docs

Reported by: DrewAPicture Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: minor Version: 3.6
Component: Inline Docs Keywords: has-patch
Focuses: Cc:

Description

_post_formats_fix_empty_title() hooks to the wp_insert_post_data filter not the save_post hook. Patch corrects the inline docs.

Attachments (2)

24303.diff (692 bytes) - added by DrewAPicture 11 months ago.
24303.2.diff (2.0 KB) - added by SergeyBiryukov 11 months ago.

Download all attachments as: .zip

Change History (6)

DrewAPicture11 months ago

comment:1 SergeyBiryukov11 months ago

  • Milestone changed from Awaiting Review to 3.6

[24043] leaves a false impression that wp_insert_post_data is an action.

We should make it clear that it's a filter: 24303.2.diff.

SergeyBiryukov11 months ago

comment:2 DrewAPicture11 months ago

Works for me. Shouldn't be any adverse affects to moving the hook, correct?

comment:3 SergeyBiryukov11 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 24233:

Update _post_formats_fix_empty_title() description. Make it clear that 'wp_insert_post_data' is a filter, not an action. props DrewAPicture. fixes #24303.

comment:4 kovshenin11 months ago

Good catch!

Note: See TracTickets for help on using tickets.