Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#24310 closed defect (bug) (fixed)

Twenty Thirteen: pixel shift can occur on gallery post format on non-single views

Reported by: lancewillett's profile lancewillett Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: low
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Reported by Mark Jaquith, only seems to happen on non-retina machines with latest Chrome version. Other browsers and retina machines not affected.

Screencast: http://screencast.com/t/4USeMoqRQDM2

Test URL: http://themebuster.wordpress.net/type/gallery/ — mouse over the peacock and bear images to see them shift slightly left.

Seems to be something with -webkit-transform. Needs investigation.

Attachments (1)

24310.diff (611 bytes) - added by jeremyfelt 12 years ago.

Download all attachments as: .zip

Change History (7)

#1 @jeremyfelt
12 years ago

Adding -webkit-backface-visibility: hidden; to the .gallery container seems to do the trick. I have no idea what else that might mess with though.

@jeremyfelt
12 years ago

#2 @jeremyfelt
12 years ago

It seemed more appropriate to put -webkit-backface-visibility: hidden; on the ... .gallery-item .gallery-icon img rules instead. 24310.diff takes that approach.

#3 @lancewillett
12 years ago

  • Keywords has-patch added
  • Priority changed from normal to low

Yep, that does the trick. @jeremyfelt would you mind sharing the research and thinking behind the fix? For posterity.

#4 follow-up: @lancewillett
12 years ago

Not going to fix yet as it's related to the image sizes in galleries -- "large" size which loads at something like 1024 pixels wide and is trimmed down with CSS to 148 pixels square.

See notes in #24307.

If we load a smaller size (I tested with both "thumbnail" and "medium") the bug reported here does not occur.

#5 in reply to: ↑ 4 @obenland
12 years ago

Replying to lancewillett:

Not going to fix yet as it's related to the image sizes in galleries -- "large" size which loads at something like 1024 pixels wide and is trimmed down with CSS to 148 pixels square.

We should add Jeremy's fix nonetheless. Even if we'd go the custom-image-size-route, that won't account for galleries that were created prior to switching to Twenty Thirteen.

#6 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24286:

Twenty Thirteen: fix pixel shift that can occur on gallery non-single views in latest Chrome. Props jeremyfelt, fixes #24310.

Note: See TracTickets for help on using tickets.