Twenty Thirteen: Make Quote Source Styling More Consistent

[celloexpressions]

I noticed some inconsistencies with quote source styling. Ultimately, it's a matter of html markup, post_formats_compat adds an em dash and uses a different syntax than the older quote posts in the theme unit test, which use <cite>.

Part of the problem is that Twenty Thirteen styles the new markup and the old (<cite>) markup differently. Patch attempts to display the older markup in a visually similar way to the new markup by adding an em dash with css and removing the inconsistent styles.

The only remaining inconsistency that I see is the color of the em dash if the source is linked, but I can't think of an non-verbose way of changing it to orange if the source is linked, while remaining as markup-agnostic as possible.

Of course, there's now way to know whether or not people included their own dashes in their citations. Maybe we don't need to add it; I only added because that's how it's formatted in the unit test. But we should at least display the citation with consistent color, underline, etc.

[celloexpressions]

Remove separate styling for older html markup, add em dash in those cases for consistency with new output.

[celloexpressions]

Top is without patch, bottom is with patch. Bottom matches style of PF UI output styling, other than the em-dash color if source is linked.

[lancewillett]

I'd vote not to make these changes; the current design and layout were specified by the theme designer (Joen) and are implemented correctly to that specification.

[celloexpressions]

The specification is to have two different layouts? Or should the output always be like the one with the dotted underline (which I'd say is better).

[lancewillett]

Two different styles ... dashed for older, red em-dash and link for newer Quote post formats.

[celloexpressions]

Well, I'm not sure why you'd want to style something that is equivalent from a user perspective (though not from a developer perspective) differently. But if that's the intention, then it's fine. Either style looks good, the inconsistency just seemed strange.