Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 5 years ago

#24324 closed enhancement (wontfix)

Placeholder support to login form

Reported by: m_uysl's profile m_uysl Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Accessibility Keywords: has-patch
Focuses: Cc:

Description

wp_login_form isn't support placeholder attribute yet. It would be good. Isn't it?

Attachments (1)

wp_login_form_placeholder_support.patch (2.0 KB) - added by m_uysl 11 years ago.
Patch updated. Placeholder support setting false as default.

Download all attachments as: .zip

Change History (11)

#1 follow-up: @toscho
11 years ago

  • Cc info@… added

What problem would this solve?

Now you have to make sure the form doesn’t look filled out already, and CSS support for placeholders is still not very good.

#2 follow-up: @SergeyBiryukov
11 years ago

Please use tabs rather than spaces for indentation (per WordPress Coding Standards).

@m_uysl
11 years ago

Patch updated. Placeholder support setting false as default.

#3 in reply to: ↑ 2 @m_uysl
11 years ago

Replying to SergeyBiryukov:

Please use tabs rather than spaces for indentation (per WordPress Coding Standards).

Actually that mistake about ide's auto formatting. Sorry for that.(patch updated )

#4 in reply to: ↑ 1 ; follow-up: @lessbloat
11 years ago

  • Keywords ui-feedback ux-feedback removed

Replying to toscho:

What problem would this solve?

That's my question as well. Both the username and the password are already wrapped with a label. Having a label of "Username", and then a placeholder of "Username" just seems redundant, no?

#5 in reply to: ↑ 4 ; follow-up: @m_uysl
11 years ago

Replying to lessbloat:

Replying to toscho:

What problem would this solve?

That's my question as well. Both the username and the password are already wrapped with a label. Having a label of "Username", and then a placeholder of "Username" just seems redundant, no?

Why it need to solve problem? Is there any requirement for it?

This changes could be useful who wants to use wp_login_formhttp://codex.wordpress.org/Function_Reference/wp_login_form in their plugin or theme.

#6 in reply to: ↑ 5 ; follow-up: @helen
11 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Replying to m_uysl:

Why it need to solve problem? Is there any requirement for it?

Yes, we should be solving problems rather than creating them. Placeholders are not to be used as substitutes for labels. Don't see what helper text you need for a username and password. So, no, I don't think core needs to add placeholder support to the login form.

#7 in reply to: ↑ 6 ; follow-up: @Caspie
10 years ago

  • Type changed from feature request to enhancement

Replying to helen:

Replying to m_uysl:

Why it need to solve problem? Is there any requirement for it?

Yes, we should be solving problems rather than creating them. Placeholders are not to be used as substitutes for labels. Don't see what helper text you need for a username and password. So, no, I don't think core needs to add placeholder support to the login form.

Well it is not a big enhancement, indeed, but I cannot agree with you that this is something that is not needed at all.

For example, I have a case with a custom login template where email is the username and I'd like to use wp_login_form instead of building custom function for it. That's because I have the placeholder texts designed but cannot filter the form to add it or have to use javascript to inject the input attributes.

I don't think it is such a big deal to add 2 more arguments with empty default values (not to match the label texts, like in the patch) to the wp_login_form.

#8 in reply to: ↑ 7 @dpik
8 years ago

Replying to Caspie:

Replying to helen:

Replying to m_uysl:

Why it need to solve problem? Is there any requirement for it?

Yes, we should be solving problems rather than creating them. Placeholders are not to be used as substitutes for labels. Don't see what helper text you need for a username and password. So, no, I don't think core needs to add placeholder support to the login form.

Well it is not a big enhancement, indeed, but I cannot agree with you that this is something that is not needed at all.

For example, I have a case with a custom login template where email is the username and I'd like to use wp_login_form instead of building custom function for it. That's because I have the placeholder texts designed but cannot filter the form to add it or have to use javascript to inject the input attributes.

I don't think it is such a big deal to add 2 more arguments with empty default values (not to match the label texts, like in the patch) to the wp_login_form.

I'm also really surprised those arguments are not implemented. Placeholders are very often asked and i don't think that adding this would break anything.

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


7 years ago

Note: See TracTickets for help on using tickets.