Placeholder support to login form

[m_uysl]

wp_login_form isn't support placeholder attribute yet. It would be good. Isn't it?

[toscho]

What problem would this solve?

Now you have to make sure the form doesn’t look filled out already, and CSS support for placeholders is still not very good.

[SergeyBiryukov]

Please use tabs rather than spaces for indentation (per ​WordPress Coding Standards).

[m_uysl]

Patch updated. Placeholder support setting false as default.

[m_uysl]

Replying to SergeyBiryukov:

Please use tabs rather than spaces for indentation (per ​WordPress Coding Standards).

Actually that mistake about ide's auto formatting. Sorry for that.(patch updated )

[lessbloat]

Replying to toscho:

What problem would this solve?

That's my question as well. Both the username and the password are already wrapped with a label. Having a label of "Username", and then a placeholder of "Username" just seems redundant, no?

[m_uysl]

Replying to lessbloat:

Replying to toscho:

What problem would this solve?

That's my question as well. Both the username and the password are already wrapped with a label. Having a label of "Username", and then a placeholder of "Username" just seems redundant, no?

Why it need to solve problem? Is there any requirement for it?

This changes could be useful who wants to use wp_login_form​http://codex.wordpress.org/Function_Reference/wp_login_form in their plugin or theme.

[helen]

Replying to m_uysl:

Why it need to solve problem? Is there any requirement for it?

Yes, we should be solving problems rather than creating them. Placeholders are not to be used as substitutes for labels. Don't see what helper text you need for a username and password. So, no, I don't think core needs to add placeholder support to the login form.

[Caspie]

Replying to helen:

Replying to m_uysl:

Why it need to solve problem? Is there any requirement for it?

Yes, we should be solving problems rather than creating them. Placeholders are not to be used as substitutes for labels. Don't see what helper text you need for a username and password. So, no, I don't think core needs to add placeholder support to the login form.

Well it is not a big enhancement, indeed, but I cannot agree with you that this is something that is not needed at all.

For example, I have a case with a custom login template where email is the username and I'd like to use wp_login_form instead of building custom function for it. That's because I have the placeholder texts designed but cannot filter the form to add it or have to use javascript to inject the input attributes.

I don't think it is such a big deal to add 2 more arguments with empty default values (not to match the label texts, like in the patch) to the wp_login_form.

[dpik]

Replying to Caspie:

Replying to helen:

Replying to m_uysl:

Why it need to solve problem? Is there any requirement for it?

Yes, we should be solving problems rather than creating them. Placeholders are not to be used as substitutes for labels. Don't see what helper text you need for a username and password. So, no, I don't think core needs to add placeholder support to the login form.

Well it is not a big enhancement, indeed, but I cannot agree with you that this is something that is not needed at all.

For example, I have a case with a custom login template where email is the username and I'd like to use wp_login_form instead of building custom function for it. That's because I have the placeholder texts designed but cannot filter the form to add it or have to use javascript to inject the input attributes.

I don't think it is such a big deal to add 2 more arguments with empty default values (not to match the label texts, like in the patch) to the wp_login_form.

I'm also really surprised those arguments are not implemented. Placeholders are very often asked and i don't think that adding this would break anything.

[SergeyBiryukov]

Follow-up: #40462