WordPress.org

Make WordPress Core

#24329 closed defect (bug) (fixed)

Twenty Thirteen: Comment Name to length stretches into comment

Reported by: rdall Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

I finally moved twenty thirteen to my actual website (yeah!) and I found an issue in a comment author area.

His nickname is CambridgeBayWeather which is 20 characters long and all one word. This make his nickname stretch into the actual comment field.
See Screenshot: http://cl.ly/image/1C313Z0Q1N1O

And Direct Link: http://robertdall.com/2013/04/29/expo-86-lies-and-wikipedia/#comment-18

Attachments (4)

24329.patch (381 bytes) - added by SergeyBiryukov 14 months ago.
24329.2.patch (492 bytes) - added by SergeyBiryukov 14 months ago.
24329.3.patch (986 bytes) - added by lancewillett 14 months ago.
Move word-wrap out of same element that uses hyphenation
24329.png (12.9 KB) - added by SergeyBiryukov 14 months ago.

Download all attachments as: .zip

Change History (14)

SergeyBiryukov14 months ago

comment:1 SergeyBiryukov14 months ago

  • Keywords has-patch added; needs-patch removed

comment:2 lancewillett14 months ago

  • Milestone changed from Awaiting Review to 3.6

comment:3 lancewillett14 months ago

I think hyphens would make more sense here. With the removal in r24153 we'll probably see a few cases like this that were "working" before because hyphens were applied to everything.

SergeyBiryukov14 months ago

comment:4 follow-up: SergeyBiryukov14 months ago

24329.2.patch uses hyphens.

I've just noticed that if both -moz-hyphens: auto and word-wrap: break-word are specified (like for .entry-content currently), Firefox ignores the former and uses the latter.

Last edited 14 months ago by SergeyBiryukov (previous) (diff)

comment:5 in reply to: ↑ 4 lancewillett14 months ago

Replying to SergeyBiryukov:

24329.2.patch uses hyphens.

I've just noticed that if both -moz-hyphens: auto and word-wrap: break-word are specified (like for .entry-content currently), Firefox ignores the former and uses the latter.

Hmm, you're right. We should probably put the word-wrap on the container element (like the article) and hyphens only on the *-content element.

lancewillett14 months ago

Move word-wrap out of same element that uses hyphenation

comment:6 lancewillett14 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24332:

Twenty Thirteen: move word-wrap rules to parent container of hyphenated text, and hyphenate long comment author names. Props SergeyBiryukov for first patches, fixes #24329.

SergeyBiryukov14 months ago

comment:7 SergeyBiryukov14 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

[24332] didn't fix the original issue for me: 24329.png.

You can see it live: http://ruproject.wordpress.com/2008/05/29/hello-world/#comment-5

Tested in Firefox 21, Chrome 27, IE 8, IE 10, Opera 12 on Windows 7 and Windows XP.

comment:8 follow-up: lancewillett14 months ago

Could it be because of language hyphenation settings? Can you try a really long name in Russian instead of English?

Otherwise we'll need to go with break-word and not hyphenation in this case.

comment:9 in reply to: ↑ 8 SergeyBiryukov14 months ago

Replying to lancewillett:

Could it be because of language hyphenation settings? Can you try a really long name in Russian instead of English?

A long name in Russian gets hyphenated in Firefox, but not in Chrome, IE or Opera (see the same link above for a live example).

comment:10 lancewillett14 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 24389:

Twenty Thirteen: revert hyphenation and word-break changes from r24332, and add better fix for long comment author names. Props SergeyBiryukov, fixes #24329 and #24451.

Note: See TracTickets for help on using tickets.