Single mode comparison broken on oldest revision since RTL commit

[a.hoereth]

When viewing the oldest revision in single mode you should see the diff {empty against initial revision}. Instead the diff is {empty against newest revision}. See Screenshots

How to reproduce:
You need a post with 3+ revisions. In normal mode view the oldest (most left) revision and compare the diff with what is being displayed when you move the slider one tick to the right.

[ocean90]

Thanks for the ticket. Mentioned it first on ​IRC chat, but was the only one. So there is definitely something going wrong here.

[adamsilverstein]

Replying to ocean90:

Thanks for the ticket. Mentioned it first on ​IRC chat, but was the only one. So there is definitely something going wrong here.

i didn't see issue before but maybe didn't understand. will look again.

[adamsilverstein]

i still can't reproduce, maybe i am missing something? are you certain you are running current trunk? are you doing something different than what i am doing?

here is a screencast of my test, my 1st revision looks fine:

​http://f.cl.ly/items/1k1a1J361x023C1h2u2Z/post-test3%20-%20Broadband.m4v

RTL mode test, also looks fine

​http://f.cl.ly/items/0T2c2k0C0w471p0B3i33/rtl-test%20-%20Broadband.m4v

[a.hoereth]

Replying to adamsilverstein:

i still can't reproduce, maybe i am missing something? are you certain you are running current trunk? are you doing something different than what i am doing?

here is a screencast of my test, my 1st revision looks fine:

​http://f.cl.ly/items/1k1a1J361x023C1h2u2Z/post-test3%20-%20Broadband.m4v

RTL mode test, also looks fine

​http://f.cl.ly/items/0T2c2k0C0w471p0B3i33/rtl-test%20-%20Broadband.m4v

Try reproducing it with "save draft" instead of "publish": ​http://www.screenr.com/cSI7
Maybe you can update the original ticket description.

[adamsilverstein]

Replying to a.hoereth:

Replying to adamsilverstein:

i still can't reproduce, maybe i am missing something? are you certain you are running current trunk? are you doing something different than what i am doing?

here is a screencast of my test, my 1st revision looks fine:

​http://f.cl.ly/items/1k1a1J361x023C1h2u2Z/post-test3%20-%20Broadband.m4v

RTL mode test, also looks fine

​http://f.cl.ly/items/0T2c2k0C0w471p0B3i33/rtl-test%20-%20Broadband.m4v

Try reproducing it with "save draft" instead of "publish": ​http://www.screenr.com/cSI7
Maybe you can update the original ticket description.

aha! thanks for clarifying! will look at this again.

[adamsilverstein]

correct reversal check for l-r comparison

[adamsilverstein]

24340.diff​​:

• corrects check for ensuring comparison always from newer->older revision, reversing special case 1st revision was corrupting later login design to compare to 'blank' initial revision (for single handle mode)

[adamsilverstein]

Replying to a.hoereth:

Replying to adamsilverstein:

i still can't reproduce, maybe i am missing something? are you certain you are running current trunk? are you doing something different than what i am doing?

here is a screencast of my test, my 1st revision looks fine:

​http://f.cl.ly/items/1k1a1J361x023C1h2u2Z/post-test3%20-%20Broadband.m4v

RTL mode test, also looks fine

​http://f.cl.ly/items/0T2c2k0C0w471p0B3i33/rtl-test%20-%20Broadband.m4v

Try reproducing it with "save draft" instead of "publish": ​http://www.screenr.com/cSI7
Maybe you can update the original ticket description.

thanks for identifying that bug - 24340.diff​​ fixes this issue, please review

[ocean90]

In 24263:

Revisions: Correct check for ensuring comparison always from newer to older revision. props adamsilverstein. fixes #24340.