It is not obvious what does "Edit" mean in the info (bottom) part of the media selection window

[mark-k]

1. Edit a post
2. click "add media"
3. select a media
4. the bottom part of the window contains an "edit" link

It seems like Edit mode just lets the user rearrange the order of the selected media. Maybe it is my english but when I rearrange icons on my desktop I don't think about it as editing. The use of "Edit" in that context just feels strange and confusing.

[wonderboymusic]

I'm having a hard time finding the "edit" link...

[mark-k]

Maybe it was an omition, maybe things changed, but right now (3.8) you will get the edit link after selecting two images.

[SergeyBiryukov]

To clarify, the ticket is about the selection editing link: tags/3.8.1/src/wp-includes/media-template.php#L253​.

[ericlewis]

It's a confusing part of the workflow here.

The "Edit" link is for reordering the selected attachments, either in the "Insert Media" or "Create gallery" workflows.

[wonderboymusic]

The drag and drop doesn't work and "Edit" is beyond ambiguous

[adamsilverstein]

change selection edit link to 'Edit selection'

[adamsilverstein]

in 24325.diff​: change link from 'Edit' to' Edit selection' - drag and drop still needs work.

[adamsilverstein]

Looks like this: ​http://cl.ly/image/2G0Y3c143R39

[ericlewis]

Have we discussed getting rid of this part of the interface? I see it as causing more confusion than solving problems, since it's creating a secondary UI element to perform the same primary task of the attachments browser (removing attachments from the selection). The secondary utility of it (reordering attachments) seems unuseful enough to jettison as well.

[adamsilverstein]

Replying to ericlewis:

Have we discussed getting rid of this part of the interface? I see it as more confusion-causing than problem-solving.

It is a UI element that's primary utility (removing attachments from the selection) is a duplicating functionality in the attachments browser . The secondary utility of it (reordering attachments) seems unuseful enough to jettison as well.

That seems reasonable, unless there is some back compat reason to keep it? One big concern is that the current main screen where you bulk select images (from post->insert media) is not accessible - its very difficult to select images and add/remove them from a group selection.

To see what I mean, try selecting a group of images with only your keyboard - selecting a group is pretty easy - one click on the first image, then a shift click on the last image to select a range. Now, try deselecting images - you can't! actioning the check/minus _removes_ the image (not the same) and actioning an image selects it, deselecting the rest.

[johnbillion]

r30685 missed this ticket.

[johnbillion]

In 30686:

Remove the sortable functionality from the selection editing toolbar at the bottom of the media manager.

Fixes #29934
See #24352
Props jessepollak

[johnbillion]

I'm going to close this as fixed following r30685 and r30686.

I think this section of the UI should stay, but if anyone thinks it should be removed (or at least removed from a given view) then open a new ticket.