WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#24356 closed enhancement (fixed)

Admin Nav Menu Walker - Strict Standards compatibility

Reported by: dvarga Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: minor Version: 3.5.1
Component: Warnings/Notices Keywords: has-patch
Focuses: Cc:

Description

Admin -> Appearance -> Menus produces some warning for me for some methods overriding abstract definitions do not follow strict standards.

Patch is here:
http://pastebin.com/6a2ugms7

Attachments (2)

strict_standard_compatibility.patch (3.0 KB) - added by dvarga 11 months ago.
Patch for strict standards compatibility
24356.patch (4.9 KB) - added by SergeyBiryukov 11 months ago.

Download all attachments as: .zip

Change History (13)

dvarga11 months ago

Patch for strict standards compatibility

comment:1 SergeyBiryukov11 months ago

  • Component changed from Menus to Warnings/Notices
  • Milestone changed from Awaiting Review to 3.6

Related: #19249, #18975

comment:2 SergeyBiryukov11 months ago

Looks like [24288] made this more prominent.

Version 0, edited 11 months ago by SergeyBiryukov (next)

comment:3 kpdesign11 months ago

Also seeing those errors, and a couple more:

Strict Standards: Declaration of WP_MS_Themes_List_Table::single_row() should be compatible with WP_List_Table::single_row($item) in xxxxx\wp-admin\includes\class-wp-ms-themes-list-table.php on line 356

(Appears at top of http://xxxxx.xxx/wp-admin/network/themes.php)

Strict Standards: Only variables should be passed by reference in xxxxx\wp-admin\includes\import.php on line 113

(Appears at top of http://xxxxx.xxx/wp-admin/import.php - single and multisite)

Running XAMPP, PHP 5.4.7, 3.6-beta3-24300.

comment:4 CNG SEO UK11 months ago

OK did the patch and still get this.

Strict Standards: Declaration of Walker_Page::start_el() should be compatible with Walker::start_el(&$output, $object, $depth = 0, $args = Array, $current_object_id = 0) in \wp-includes\post-template.php on line 1103

Strict Standards: Declaration of Walker_PageDropdown::start_el() should be compatible with Walker::start_el(&$output, $object, $depth = 0, $args = Array, $current_object_id = 0) in \wp-includes\post-template.php on line 1149

Strict Standards: Declaration of Walker_CategoryDropdown::start_el() should be compatible with Walker::start_el(&$output, $object, $depth = 0, $args = Array, $current_object_id = 0) in \category-template.php on line 949

Strict Standards: Declaration of Walker_Comment::start_el() should be compatible with Walker::start_el(&$output, $object, $depth = 0, $args = Array, $current_object_id = 0) in \wp-includes\comment-template.php on line 1476

I am running the nightly build (3.6-beta3-24330)
On Apache/2.4.4 (Win32) OpenSSL/1.0.1e PHP/5.4.15

comment:5 michelwppi11 months ago

I am running (MacOSX) the nightly build (3.6-beta3-24372)
On MAMP PHP - 5.4.10

PHP.INI set : error_reporting = E_ALL

Strict Standards: Declaration of Walker_Nav_Menu_Edit::start_lvl() should be compatible with Walker::start_lvl(&$output, $depth = 0, $args = Array) in /Applications/MAMP/htdocs/wp_36/wp-admin/includes/nav-menu.php on line 10

Strict Standards: Declaration of Walker_Nav_Menu_Checklist::start_lvl() should be compatible with Walker::start_lvl(&$output, $depth = 0, $args = Array) in /Applications/MAMP/htdocs/wp_36/wp-admin/includes/nav-menu.php on line 227

SergeyBiryukov11 months ago

comment:6 SergeyBiryukov11 months ago

In 24377:

Fix E_STRICT notices in walkers. props dvarga. see #24356.

comment:7 SergeyBiryukov11 months ago

In 24378:

Fix E_STRICT notice in wp_get_popular_importers(). see #24356.

comment:8 SergeyBiryukov11 months ago

WP_MS_Themes_List_Table::single_row() doesn't use $key parameter (see [16361]).

comment:9 SergeyBiryukov11 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 24379:

Fix E_STRICT notice in WP_MS_Themes_List_Table::single_row(). fixes #24356.

comment:10 Denis-de-Bernardy11 months ago

There are still errors when browsing wp-admin/theme-install.php:

Strict standards: Declaration of WP_Theme_Install_List_Table::_js_vars() should be compatible with WP_List_Table::_js_vars() in (....)/wp-admin/includes/class-wp-theme-install-list-table.php on line 394

comment:11 SergeyBiryukov11 months ago

In 24409:

Fix E_STRICT notice in WP_Theme_Install_List_Table::_js_vars(). see #24356.

Note: See TracTickets for help on using tickets.