WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#24363 closed defect (bug) (fixed)

Twenty Thirteen: Phpdoc param descriptions in back-compat.php

Reported by: DrewAPicture Owned by: lancewillett
Priority: normal Milestone: 3.6
Component: Bundled Theme Version: 3.6
Severity: normal Keywords: has-patch
Cc: Focuses:

Description (last modified by DrewAPicture)

Patch adds param descriptions for twentythirteen_switch_theme() in /inc/back-compat.php

Attachments (2)

24363.patch​ (741 bytes ) - added by DrewAPicture 13 years ago.
24363.2.patch​ (564 bytes ) - added by DrewAPicture 13 years ago.
phpdoc

Download all attachments as: .zip

Change History (6)

@DrewAPicture
13 years ago

#1 @DrewAPicture
13 years ago

  • Description modified (diff)
  • Summary Twenty Thirteen: Phpdoc param descriptions in back-compat.php → Twenty Thirteen: Remove unused param in twentythirteen_switch_theme()

#2 @SergeyBiryukov
13 years ago

theme_name cannot be removed. after_switch_theme action passes the old theme object as the second argument: tags/3.5.1/wp-includes/theme.php#L1612​.

#3 @DrewAPicture
13 years ago

  • Description modified (diff)
  • Summary Twenty Thirteen: Remove unused param in twentythirteen_switch_theme() → Twenty Thirteen: Phpdoc param descriptions in back-compat.php

Yeah, oops on the number of args passed to the filter. Changing back to original title/desc.

@DrewAPicture
13 years ago

phpdoc

#4 @lancewillett
13 years ago

  • Owner set to lancewillett
  • Resolution → fixed
  • Status new → closed

In 24307:

Twenty Thirteen: PHPDoc improvements for back-compat file, props DrewAPicture. Fixes #24363.

Note: See TracTickets for help on using tickets.