WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#24365 closed defect (bug) (fixed)

Suppressed errors during install

Reported by: SergeyBiryukov Owned by: nacin
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Warnings/Notices Keywords: has-patch
Focuses: Cc:

Description

Reported in http://wordpress.org/support/topic/36-beta3-24284-throws-a-stream-of-suppressed-errors-during-install:

PHP Strict standards:  Redefining already defined constructor for class WP_Widget in .../wp-includes/widgets.php on line 93
PHP Notice:  unserialize(): Error at offset 0 of 38 bytes in .../wp-admin/includes/upgrade.php on line 1420
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 589
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 622
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 644
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 655
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 662
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 675
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 675
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 696
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 702
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 708
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 720
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 733
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 746
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 760
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 774
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 787

Attachments (2)

24365.diff (521 bytes) - added by leewillis77 2 years ago.
Possible patch
24365-2.diff (547 bytes) - added by leewillis77 2 years ago.
Revised patch

Download all attachments as: .zip

Change History (7)

comment:1 @SergeyBiryukov2 years ago

See #20801 for WP_Widget constructor.

comment:2 @SergeyBiryukov2 years ago

#24438 has a patch for the strict notices.

Let's try to fix the unserialize() notice here.

@leewillis772 years ago

Possible patch

comment:3 @leewillis772 years ago

Looks like we can just use maybe_unserialize() here instead of unserialize. We can probably drop the @ as well?

comment:4 @SergeyBiryukov2 years ago

  • Keywords has-patch added

@leewillis772 years ago

Revised patch

comment:5 @nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24625:

Use maybe_unserialize() in upgrade.php's private get_option() function. This actually predates maybe_unserialize() ([2487], [3234]). props leewillis77. fixes #24365.

Note: See TracTickets for help on using tickets.