WordPress.org

Make WordPress Core

#24372 closed defect (bug) (fixed)

Text_Diff: Deprecated and Strict Standards PHP warnings

Reported by: ocean90 Owned by: ocean90
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Warnings/Notices Keywords:
Focuses: Cc:

Description

Since [24288].

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff.php on line 380

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff.php on line 402

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff.php on line 424

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff.php on line 446

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Renderer.php on line 101

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Renderer.php on line 121

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Engine/native.php on line 107

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Engine/native.php on line 122

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Engine/native.php on line 124

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Engine/native.php on line 126

Strict Standards: array_walk() expects parameter 2 to be a valid callback, non-static method Text_Diff::trimNewlines() should not be called statically in /wp-includes/Text/Diff/Engine/native.php on line 33

Strict Standards: array_walk() expects parameter 2 to be a valid callback, non-static method Text_Diff::trimNewlines() should not be called statically in /wp-includes/Text/Diff/Engine/native.php on line 34

Upstream is http://www.horde.org/libraries/Horde_Text_Diff. There is a newer version, but it's NOT back compatible.

Attachments (1)

24372.diff (507 bytes) - added by aaroncampbell 11 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 nacin11 months ago

In 24362:

Remove deprecated pass-by-reference from the Text_Diff external library. Upstream is not back compat. see #24372.

aaroncampbell11 months ago

comment:2 aaroncampbell11 months ago

24372.diff fixes the last few notices by making Text_Diff::trimNewlines() static, which is the only way it's ever used.

comment:3 ocean9011 months ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 24363:

Declare Text_Diff::trimNewlines() as static. Upstream is not back compat. props aaroncampbell. fixes #24372.

Note: See TracTickets for help on using tickets.