Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24374 closed defect (bug) (fixed)

Change to wp_unslash breaks ms-files if_none_match handling

Reported by: devesine's profile devesine Owned by: nacin's profile nacin
Milestone: 3.6 Priority: normal
Severity: critical Version: 3.6
Component: Multisite Keywords: has-patch
Focuses: Cc:

Description

In [23591], ms-files.php was updated to use wp_unslash instead of stripslashes. Since ms-files.php uses SHORTINIT, formatting.php is not loaded and therefore wp_unslash is not available. This causes ms-files to fatal out (Call to undefined function wp_unslash()) when trying to handle a request with an If-None-Match header.

The patch switches back to stripslashes (following the vague lead of functions.php avoiding formatting.php dependency).

Attachments (1)

24374-ms-files-stripslashes.diff (766 bytes) - added by devesine 11 years ago.

Download all attachments as: .zip

Change History (3)

#1 @ocean90
11 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.6
  • Severity changed from normal to critical

#2 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24305:

Use stripslashes() instead of wp_unslash() in ms-files.php to avoid formatting.php dependency. props devesine, fixes #24374.

Note: See TracTickets for help on using tickets.