WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 8 weeks ago

#24378 closed enhancement (worksforme)

Filter to hide post format icons in list table

Reported by: DrewAPicture Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.6
Component: Post Formats Keywords: has-patch
Focuses: Cc:

Description

True to form of being able to hide the Post Formats UI, we should have a like-filter to hide the post format icons in the list table.

Patch attached.

Attachments (2)

24378.patch (980 bytes) - added by DrewAPicture 11 months ago.
24378.2.patch (1.2 KB) - added by DrewAPicture 4 months ago.
Boolean filter with docs

Download all attachments as: .zip

Change History (11)

DrewAPicture11 months ago

comment:1 follow-up: helen11 months ago

Seems like that should be a screen option, no?

comment:2 in reply to: ↑ 1 DrewAPicture11 months ago

Replying to helen:

Seems like that should be a screen option, no?

That's another option, sure. I figured the filter was the most ideal in terms of overhead at this point in the cycle.

My only hesitation in doing it with a screen option is that screen options are traditionally used to hide/show list table columns (in this context) and since we chose in #16047 to do formats as appended icons instead of a column, maybe we should avoid breaking the precedent. Thoughts?

comment:3 greenshady11 months ago

  • Cc justin@… added

comment:4 toscho11 months ago

  • Cc info@… added

comment:5 dway11 months ago

For me, this solution seems to be more straightforward : #24059

Last edited 11 months ago by SergeyBiryukov (previous) (diff)

DrewAPicture4 months ago

Boolean filter with docs

comment:6 DrewAPicture4 months ago

  • Keywords ux-feedback removed
  • Milestone changed from Awaiting Review to 3.9

Moving to 3.9 for consideration. I think we can probably just use a boolean filter here to enable or disable the format icons.

In 24378.2.patch I only passed the boolean value as is the style with this type of filter, but we could certainly pass the format, even the post object as well. I'd be happy with the simple enable/disabled ability.

comment:7 follow-up: markjaquith3 months ago

Does this really need a filter? Can't someone just hide it with CSS?

comment:8 in reply to: ↑ 7 DrewAPicture3 months ago

Replying to markjaquith:

Does this really need a filter? Can't someone just hide it with CSS?

I'd view hiding via CSS as kind of a hack, if only because the icon is displayed as part of the row output in the list table. If the icon was simply decoration, I'd agree with you, but it's a functional, clickable link.

Last edited 3 months ago by DrewAPicture (previous) (diff)

comment:9 nacin8 weeks ago

  • Milestone 3.9 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

I agree with Mark. I think CSS is sufficient here and don't see this as a hack.

Note: See TracTickets for help on using tickets.