Filter to hide post format icons in list table

[DrewAPicture]

True to form of being able to hide the Post Formats UI, we should have a like-filter to hide the post format icons in the list table.

Patch attached.

[helen]

Seems like that should be a screen option, no?

[DrewAPicture]

Replying to helen:

Seems like that should be a screen option, no?

That's another option, sure. I figured the filter was the most ideal in terms of overhead at this point in the cycle.

My only hesitation in doing it with a screen option is that screen options are traditionally used to hide/show list table columns (in this context) and since we chose in #16047 to do formats as appended icons instead of a column, maybe we should avoid breaking the precedent. Thoughts?

[dway]

For me, this solution seems to be more straightforward : #24059

[DrewAPicture]

Boolean filter with docs

[DrewAPicture]

Moving to 3.9 for consideration. I think we can probably just use a boolean filter here to enable or disable the format icons.

In 24378.2.patch​ I only passed the boolean value as is the style with this type of filter, but we could certainly pass the format, even the post object as well. I'd be happy with the simple enable/disabled ability.

[markjaquith]

Does this really need a filter? Can't someone just hide it with CSS?

[DrewAPicture]

Replying to markjaquith:

Does this really need a filter? Can't someone just hide it with CSS?

I'd view hiding via CSS as kind of a hack, if only because the icon is displayed as part of the row output in the list table. If the icon was simply decoration, I'd agree with you, but it's a functional, clickable link.

[nacin]

I agree with Mark. I think CSS is sufficient here and don't see this as a hack.