Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #24380, comment 33


Ignore:
Timestamp:
07/01/2014 03:59:33 PM (10 years ago)
Author:
mikemanger
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24380, comment 33

    initial v1  
    22> 2. In the `png_compression_level` filter docs, it's mentioned that there are two different contexts possible, yet the filter is only evaluated one place in the codebase and the context isn't dynamic. So where would the second context enter the picture? Also, the contexts should be spelled out for the `$context` parameter, not in the long description area.
    33
    4 In [attachment:24380.4.2.patch] I have removed the context parameter. I copied it from the `jpeg_quality` filter above so the context parameter should probably be removed or deprecated there as well (looks like it came from the old `image_resize` function).
     4In [attachment:24380.4.2.patch] I have removed the context parameter. I orignally copied it from the `jpeg_quality` filter above so the context parameter should probably be removed or deprecated there as well (looks like it came from the old `image_resize` function).