Revisions needs a functional fallback for no-js

[DrewAPicture]

Since editing, comparing and restoring revisions requires javascript, we should not make it possible open revisions from the editing screen.

In the patch, I took a stab at adding an error message to the Revisions metabox as well as a solution for disabling the edit link if no-js. Not a huge fan of tacking on an extra span to $date just for no-js, but as far as I'm aware, we don't have a way to test for javascript support in PHP.

[nacin]

Was this stuff js-only in 3.5?

[DrewAPicture]

Replying to nacin:

Was this stuff js-only in 3.5?

Looking at 3.5 with no-js, seems like you could compare, review and restore with no-js. It was my impression that revisions in 3.6+ is Backbone-reliant for almost everything.

[DrewAPicture]

I pretty much get an endless spinner and basically blank page with no-js:

[nacin]

Then that's bad. We can't degrade like that.

The best solution would likely be to keep the old UI as a no-JS fallback.

[nacin]

We're considering dropping revisions for no-JS entirely. It's a fairly esoteric feature. If we do that, we'll need to also hide the links in the meta box (but may not need to hide the meta box itself).

[DrewAPicture]

@nacin:

The original patch hid the links in a not-exactly-awesome way, but at least users could see they had revisions. I'm not sure there's much value in seeing the revisions list without being able to restore and compare them, unless we make it apparent that turning on Javascript would enable the feature.

On that token, we don't necessarily have to introduce a unique string here, in fact we could create a generalized, reusable one, like 'Javascript must be enabled to use this feature.', or something. Thoughts?

[MikeHansenMe]

minor update to previous patch

[MikeHansenMe]

I like the generic string that can be reused if it is ever needed. I also added <p> tags to the warning.

[DrewAPicture]

24405.2.patch​ tweaks the generic string and hides the unordered list for no-js. I opted to remove the error class because it's not really an error, more of a notification.

Just to give you an idea, this is what it looked like with the error class still applied:

[markjaquith]

In 24557:

Hide the Revisions meta box content if no-JS, as JS is required to actually do anything with revisions.

fixes #24405. props DrewAPicture, MikeHansenMe.