WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#24407 closed defect (bug) (fixed)

Twenty Thirteen: Misalignment of images in image post formats that use captions

Reported by: tollmanz Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: close
Focuses: Cc:

Description

If you upload an image to a post that uses the image post format and include a caption, the image will be misaligned on the posts page.

http://f.cl.ly/items/0b2v0o1N2I0t1z3y0K3l/caption-misalignment-1.png

Full sized image

To recreate:

  1. Add a new post
  2. Choose "Image"
  3. Add an image via the media uploader
  4. Add a caption to the image
  5. Save and view the post

The misalignment occurs on the posts page and the individual post page.

Attachments (1)

24407.patch (399 bytes) - added by tollmanz 2 years ago.

Download all attachments as: .zip

Change History (9)

@tollmanz2 years ago

comment:1 @tollmanz2 years ago

My patch seems to fix this issue, but I am not sure if we should add specific styles for the other alignment values.

comment:2 @lancewillett2 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.6

comment:3 follow-up: @lancewillett2 years ago

@tollmanz Can you also try to repeat with an image that is 724 pixels wide or bigger? We have that as the "minimum" recommended size for the image post format.

comment:4 @lancewillett2 years ago

My guess is this only occurs if the image is smaller than 724 (but need to confirm that).

comment:5 @lancewillett2 years ago

By the way, the image without alignment *should* hang left, not be centered. So the bug here is the captioned image should do the same -- not be centered, unless specifically set to aligncenter in the Media editor.

comment:6 in reply to: ↑ 3 @tollmanz2 years ago

Replying to lancewillett:

@tollmanz Can you also try to repeat with an image that is 724 pixels wide or bigger? We have that as the "minimum" recommended size for the image post format.

Lance, the image appears aligned correctly if you use an image that is 724px wide. I still think images that are less than 724px should align correctly.

comment:7 @lancewillett2 years ago

  • Keywords close added; has-patch removed

This will be fixed once #24469 changes are committed.

comment:8 @lancewillett2 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24391:

Twenty Thirteen: remove all post_format_*() and the_remaining_content() function calls, reverting to the_content(). Simplify functions.php, JS, and CSS files accordingly. Props obenland for starter patch, fixes #24469 and #24407. See #24452.

Note: See TracTickets for help on using tickets.