WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#24413 closed enhancement (fixed)

Twenty Thirteen: phpdoc cleanup/completion

Reported by: DrewAPicture Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Patch adds some missing tag descriptions, fixes a reference to the wrong function and some other grammatical stuff.

Attachments (2)

24413.patch (3.3 KB) - added by DrewAPicture 2 years ago.
24413.2.patch (3.0 KB) - added by DrewAPicture 2 years ago.

Download all attachments as: .zip

Change History (8)

@DrewAPicture2 years ago

comment:1 @DrewAPicture2 years ago

  • Version changed from 3.5.1 to trunk

comment:2 @lancewillett2 years ago

Thanks for this. Two questions:

  1. Why does the "Printed meta includes:" need to be on separate lines?
  2. "Sets up special body classes." isn't really needed, right? Just put a space after the first sentence there, starting with "Extends."

comment:3 @DrewAPicture2 years ago

  1. It doesn't have to be. Seemed like better fodder for a long description.
  2. It needs a short description, doesn't have to be that, though.

@DrewAPicture2 years ago

comment:4 follow-up: @DrewAPicture2 years ago

24413.2.patch restores the short description for twentythirteen_entry_meta() and fixes the short description on twentythirteen_body_class(). We need a full stop at the end of the short description. Full stop. :)

comment:5 in reply to: ↑ 4 @lancewillett2 years ago

Replying to DrewAPicture:

24413.2.patch restores the short description for twentythirteen_entry_meta() and fixes the short description on twentythirteen_body_class(). We need a full stop at the end of the short description. Full stop. :)

Cool, makes sense. Thanks for the ticket + patch!

comment:6 @lancewillett2 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24351:

Twenty Thirteen: PHPDoc cleanup/completion, props DrewAPicture. Fixes #24413.

Note: See TracTickets for help on using tickets.