WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #24425, comment 14


Ignore:
Timestamp:
07/04/2013 08:23:24 AM (9 years ago)
Author:
markjaquith
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24425, comment 14

    initial v1  
    11[attachment:24425.history-debounce.diff​ 24425.history-debounce.diff]
    22
    3 The URL updating on mouse drag was massively slowing things down. This patch makes a debounced function (250ms currently), and then only calls that from a custom event that fires after the diff has rendered (diff rendering has its own throttling built in, so this will filter out diffId changes that happen so quickly that by the time they start to render, the diffId has already changed.
     3The URL updating on mouse drag was massively slowing things down. This patch makes a debounced function (250ms currently), and then only calls that from a custom event that fires after the diff has rendered (diff rendering has its own throttling built in, so this will filter out diffId changes that happen so quickly that by the time they start to render, the diffId has already changed).
    44
    55Also a little bit of cleanup, removing unnecessary variables, and moving the Router to get passed in a model, instead of the set-it-after thing that was happening.